2009-03-16 11:24:47

by Martin Peschke

[permalink] [raw]
Subject: [Patch] relay: fix signedness in subbuf_splice_actor()

From: Martin Peschke <[email protected]>

The variable ret is used as a signed value.
Found by a statical code analysis tool.

Signed-off-by: Martin Peschke <[email protected]>

---
kernel/relay.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -1227,7 +1227,8 @@ static int subbuf_splice_actor(struct fi
unsigned int flags,
int *nonpad_ret)
{
- unsigned int pidx, poff, total_len, subbuf_pages, nr_pages, ret;
+ unsigned int pidx, poff, total_len, subbuf_pages, nr_pages;
+ int ret;
struct rchan_buf *rbuf = in->private_data;
unsigned int subbuf_size = rbuf->chan->subbuf_size;
uint64_t pos = (uint64_t) *ppos;