2009-03-19 15:32:57

by Richard Kennedy

Subject: [PATCH] ipv6: reorder struct inet6_ifaddr to remove padding on 64 bit builds

reorder struct inet6_ifaddr to remove padding on 64 bit builds

remove 8 bytes of padding so inet6_ifaddr becomes 192 bytes & fits into
a smaller slab.

Signed-off-by: Richard Kennedy <[email protected]>
----
patch against v2.6.29-rc8

I've compiled & booted with this patch, modules ipv6 & ip6_tables load
successfully, but I've not run any other tests.

regards
Richard




diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h
index c8effa4..38b7813 100644
--- a/include/net/if_inet6.h
+++ b/include/net/if_inet6.h
@@ -39,8 +39,6 @@ struct inet6_ifaddr

__u32 valid_lft;
__u32 prefered_lft;
- unsigned long cstamp; /* created timestamp */
- unsigned long tstamp; /* updated timestamp */
atomic_t refcnt;
spinlock_t lock;

@@ -49,6 +47,9 @@ struct inet6_ifaddr

__u16 scope;

+ unsigned long cstamp; /* created timestamp */
+ unsigned long tstamp; /* updated timestamp */
+
struct timer_list timer;

struct inet6_dev *idev;

2009-03-21 20:29:42

by David Miller

Subject: Re: [PATCH] ipv6: reorder struct inet6_ifaddr to remove padding on 64 bit builds

From: Richard Kennedy <[email protected]>
Date: Thu, 19 Mar 2009 15:32:40 +0000

> reorder struct inet6_ifaddr to remove padding on 64 bit builds
>
> remove 8 bytes of padding so inet6_ifaddr becomes 192 bytes & fits into
> a smaller slab.
>
> Signed-off-by: Richard Kennedy <[email protected]>

Applied, thanks.