2009-03-23 16:24:29

by Daniel Mack

[permalink] [raw]
Subject: [PATCH] imx_udc: fix leak in imx_ep_alloc_request()

cppcheck found another leak in drivers/usb/gadget/imx_udc.c

Cc: Mike Lee <[email protected]>
Cc: Darius Augulis <[email protected]>
Signed-off-by: Daniel Mack <[email protected]>
---
drivers/usb/gadget/imx_udc.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c
index 77c5d0a..3ccd92c 100644
--- a/drivers/usb/gadget/imx_udc.c
+++ b/drivers/usb/gadget/imx_udc.c
@@ -718,9 +718,12 @@ static struct usb_request *imx_ep_alloc_request
{
struct imx_request *req;

+ if (!usb_ep)
+ return NULL;
+
req = kzalloc(sizeof *req, gfp_flags);
- if (!req || !usb_ep)
- return 0;
+ if (!req)
+ return NULL;

INIT_LIST_HEAD(&req->queue);
req->in_use = 0;
--
1.6.2