2009-04-02 23:33:25

by Kevin Cernekee

Subject: [PATCH] MTD: nandsim should delete its partitions on module unload

Signed-off-by: Kevin Cernekee <[email protected]>
---
drivers/mtd/nand/nandsim.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
index cd0711b..f4fda9b 100644
--- a/drivers/mtd/nand/nandsim.c
+++ b/drivers/mtd/nand/nandsim.c
@@ -2349,6 +2349,7 @@ static void __exit ns_cleanup_module(void)
struct nandsim *ns = (struct nandsim *)(((struct nand_chip
*)nsmtd->priv)->priv);
int i;

+ del_mtd_partitions(nsmtd);
free_nandsim(ns); /* Free nandsim private resources */
nand_release(nsmtd); /* Unregister driver */
for (i = 0;i < ARRAY_SIZE(ns->partitions); ++i)
--
1.5.6.3

2009-04-03 06:57:21

by Adrian Hunter

Subject: Re: [PATCH] MTD: nandsim should delete its partitions on module unload

Kevin Cernekee wrote:
> Signed-off-by: Kevin Cernekee <[email protected]>
> ---
> drivers/mtd/nand/nandsim.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index cd0711b..f4fda9b 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -2349,6 +2349,7 @@ static void __exit ns_cleanup_module(void)
> struct nandsim *ns = (struct nandsim *)(((struct nand_chip
> *)nsmtd->priv)->priv);
> int i;
>
> + del_mtd_partitions(nsmtd);
> free_nandsim(ns); /* Free nandsim private resources */
> nand_release(nsmtd); /* Unregister driver */
> for (i = 0;i < ARRAY_SIZE(ns->partitions); ++i)

Doesn't nand_release() already do that?

2009-04-03 07:02:55

by Artem Bityutskiy

Subject: Re: [PATCH] MTD: nandsim should delete its partitions on module unload

On Thu, 2009-04-02 at 16:32 -0700, Kevin Cernekee wrote:
> Signed-off-by: Kevin Cernekee <[email protected]>
> ---
> drivers/mtd/nand/nandsim.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index cd0711b..f4fda9b 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -2349,6 +2349,7 @@ static void __exit ns_cleanup_module(void)
> struct nandsim *ns = (struct nandsim *)(((struct nand_chip
> *)nsmtd->priv)->priv);
The patch is line-wrapped.

> int i;
>
> + del_mtd_partitions(nsmtd);
> free_nandsim(ns); /* Free nandsim private resources */
> nand_release(nsmtd); /* Unregister driver */
> for (i = 0;i < ARRAY_SIZE(ns->partitions); ++i)

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)

2009-04-03 20:20:49

by Kevin Cernekee

Subject: Re: [PATCH] MTD: nandsim should delete its partitions on module unload

On Thu, Apr 2, 2009 at 11:57 PM, Adrian Hunter <[email protected]> wrote:
> Doesn't nand_release() already do that?

Yes. The problem I was seeing (attempt to reregister mtd* sysfs
entries) was caused by something else. I retract the patch.

Thanks.