2009-04-04 18:06:17

by Adrian McMenamin

[permalink] [raw]
Subject: CONFIG_FW_LOADER

Currently the help for this states:


CONFIG_FW_LOADER:
This option is provided for the case where no in-kernel-tree modules
require userspace firmware loading support, but a module built outside
the kernel tree does.


Is it just me or is this somewhat misleading? Don't all modules that
load firmware from userspace require this?


2009-04-05 04:18:24

by Marcel Holtmann

[permalink] [raw]
Subject: Re: CONFIG_FW_LOADER

Hi Adrian,

> Currently the help for this states:
>
>
> CONFIG_FW_LOADER:
> This option is provided for the case where no in-kernel-tree modules
> require userspace firmware loading support, but a module built outside
> the kernel tree does.
>
>
> Is it just me or is this somewhat misleading? Don't all modules that
> load firmware from userspace require this?

all drivers that do use 'select FW_LOADER' and so they trigger building
this module anyway. The config option is purely if you have a driver
that is built outside the tree and wanna use request_firmware().

Regards

Marcel

2009-04-05 11:01:41

by Adrian McMenamin

[permalink] [raw]
Subject: Re: CONFIG_FW_LOADER

On Sun, 2009-04-05 at 06:18 +0200, Marcel Holtmann wrote:
> Hi Adrian,
>
> > Currently the help for this states:
> >
> >
> > CONFIG_FW_LOADER:
> > This option is provided for the case where no in-kernel-tree modules
> > require userspace firmware loading support, but a module built outside
> > the kernel tree does.
> >
> >
> > Is it just me or is this somewhat misleading? Don't all modules that
> > load firmware from userspace require this?
>
> all drivers that do use 'select FW_LOADER' and so they trigger building
> this module anyway. The config option is purely if you have a driver
> that is built outside the tree and wanna use request_firmware().
>

OK. Guess the issue is that my module doesn't select this. I'll patch
that.