Observed the following build error:
CC drivers/net/ibm_newemac/core.o
drivers/net/ibm_newemac/core.c: In function ‘emac_probe’:
drivers/net/ibm_newemac/core.c:2831: error: ‘struct net_device’ has no
member named ‘open’
drivers/net/ibm_newemac/core.c:2834: error: ‘struct net_device’ has no
member named ‘tx_timeout’
drivers/net/ibm_newemac/core.c:2836: error: ‘struct net_device’ has no
member named ‘stop’
drivers/net/ibm_newemac/core.c:2837: error: ‘struct net_device’ has no
member named ‘get_stats’
drivers/net/ibm_newemac/core.c:2838: error: ‘struct net_device’ has no
member named ‘set_multicast_list’
drivers/net/ibm_newemac/core.c:2839: error: ‘struct net_device’ has no
member named ‘do_ioctl’
drivers/net/ibm_newemac/core.c:2841: error: ‘struct net_device’ has no
member named ‘hard_start_xmit’
drivers/net/ibm_newemac/core.c:2842: error: ‘struct net_device’ has no
member named ‘change_mtu’
drivers/net/ibm_newemac/core.c:2845: error: ‘struct net_device’ has no
member named ‘hard_start_xmit’
make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1
make[2]: *** [drivers/net/ibm_newemac] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Regards--
Subrata
Observed the following error:
BLD FW drivers/net/wan/wanxlfw.inc
/bin/sh: as68k: command not found
make[3]: *** [drivers/net/wan/wanxlfw.inc] Error 127
make[2]: *** [drivers/net/wan] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Regards--
Subrata
On Apr 9, 2009, at 8:52 AM, Subrata Modak wrote:
> Observed the following build error:
>
> CC drivers/net/ibm_newemac/core.o
> drivers/net/ibm_newemac/core.c: In function ?emac_probe?:
> drivers/net/ibm_newemac/core.c:2831: error: ?struct net_device? has no
> member named ?open?
> drivers/net/ibm_newemac/core.c:2834: error: ?struct net_device? has no
> member named ?tx_timeout?
> drivers/net/ibm_newemac/core.c:2836: error: ?struct net_device? has no
> member named ?stop?
> drivers/net/ibm_newemac/core.c:2837: error: ?struct net_device? has no
> member named ?get_stats?
> drivers/net/ibm_newemac/core.c:2838: error: ?struct net_device? has no
> member named ?set_multicast_list?
> drivers/net/ibm_newemac/core.c:2839: error: ?struct net_device? has no
> member named ?do_ioctl?
> drivers/net/ibm_newemac/core.c:2841: error: ?struct net_device? has no
> member named ?hard_start_xmit?
> drivers/net/ibm_newemac/core.c:2842: error: ?struct net_device? has no
> member named ?change_mtu?
> drivers/net/ibm_newemac/core.c:2845: error: ?struct net_device? has no
> member named ?hard_start_xmit?
> make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1
> make[2]: *** [drivers/net/ibm_newemac] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> Regards--
> Subrata
>
> <randconfig4-ppc64-next20090409.txt>
This is because CONFIG_COMPAT_NET_DEV_OPS isnt set and needs to be for
this driver to build. I've asked the netdev guys about either fixing
the driver or adding the proper thing to Kconfig to select
CONFIG_COMPAT_NET_DEV_OPS.
- k-
On Thu, Apr 09, 2009 at 09:28:23AM -0500, Kumar Gala wrote:
>
> On Apr 9, 2009, at 8:52 AM, Subrata Modak wrote:
>
>> Observed the following build error:
>>
>> CC drivers/net/ibm_newemac/core.o
>> drivers/net/ibm_newemac/core.c: In function ‘emac_probe’:
>> drivers/net/ibm_newemac/core.c:2831: error: ‘struct net_device’ has no
>> member named ‘open’
>> drivers/net/ibm_newemac/core.c:2834: error: ‘struct net_device’ has no
>> member named ‘tx_timeout’
>> drivers/net/ibm_newemac/core.c:2836: error: ‘struct net_device’ has no
>> member named ‘stop’
>> drivers/net/ibm_newemac/core.c:2837: error: ‘struct net_device’ has no
>> member named ‘get_stats’
>> drivers/net/ibm_newemac/core.c:2838: error: ‘struct net_device’ has no
>> member named ‘set_multicast_list’
>> drivers/net/ibm_newemac/core.c:2839: error: ‘struct net_device’ has no
>> member named ‘do_ioctl’
>> drivers/net/ibm_newemac/core.c:2841: error: ‘struct net_device’ has no
>> member named ‘hard_start_xmit’
>> drivers/net/ibm_newemac/core.c:2842: error: ‘struct net_device’ has no
>> member named ‘change_mtu’
>> drivers/net/ibm_newemac/core.c:2845: error: ‘struct net_device’ has no
>> member named ‘hard_start_xmit’
>> make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1
>> make[2]: *** [drivers/net/ibm_newemac] Error 2
>> make[1]: *** [drivers/net] Error 2
>> make: *** [drivers] Error 2
>>
>> Regards--
>> Subrata
>>
>> <randconfig4-ppc64-next20090409.txt>
>
> This is because CONFIG_COMPAT_NET_DEV_OPS isnt set and needs to be for
> this driver to build. I've asked the netdev guys about either fixing
> the driver or adding the proper thing to Kconfig to select
> CONFIG_COMPAT_NET_DEV_OPS.
Thanks!
If someone has pointers on what needs to be done to fix it, let me know.
josh
On Thu, 9 Apr 2009, Subrata Modak wrote:
> Observed the following error:
>
> BLD FW drivers/net/wan/wanxlfw.inc
> /bin/sh: as68k: command not found
> make[3]: *** [drivers/net/wan/wanxlfw.inc] Error 127
> make[2]: *** [drivers/net/wan] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
Yeah, if you enable CONFIG_WANXL_BUILD_FIRMWARE without
CONFIG_PREVENT_FIRMWARE_BUILD (the trick for allmodconfig?), you need the
appropriate tools installed...
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Techsoft Centre Europe
The Corporate Village ? Da Vincilaan 7-D1 ? B-1935 Zaventem ? Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/
A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 ? RPR Brussels
Fortis ? BIC GEBABEBB ? IBAN BE41293037680010
Observed this build failure:
MODPOST vmlinux.o
WARNING: modpost: Found 6 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
drivers/built-in.o: In function `musb_free':
/root/subrata/kernels/linux-2.6.30-rc1-randconfig12/drivers/usb/musb/musb_core.c:1837: undefined reference to `dma_controller_destroy'
drivers/built-in.o: In function `musb_init_controller':
/root/subrata/kernels/linux-2.6.30-rc1-randconfig12/drivers/usb/musb/musb_core.c:1950: undefined reference to `dma_controller_create'
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
make: *** [.tmp_vmlinux1] Error 1
Regards--
Subrata
Observed the following build error:
drivers/scsi/aha1542.c: In function ‘BAD_SG_DMA’:
drivers/scsi/aha1542.c:61: error: implicit declaration of function
‘isa_page_to_bus’
drivers/scsi/aha1542.c: In function ‘aha1542_intr_handle’:
drivers/scsi/aha1542.c:495: error: implicit declaration of function
‘isa_virt_to_bus’
make[2]: *** [drivers/scsi/aha1542.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2
Regards--
Subrata
Observed the following build errors:
Building modules, stage 2.
MODPOST 549 modules
ERROR: ".lro_receive_skb" [drivers/net/pasemi_mac_driver.ko] undefined!
ERROR: ".lro_flush_all" [drivers/net/pasemi_mac_driver.ko] undefined!
WARNING: modpost: Found 8 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Regards--
Subrata
Observed the following build error:
Building modules, stage 2.
MODPOST 648 modules
ERROR: ".hvc_put_chars" [drivers/char/hvcs.ko] undefined!
ERROR: ".hvc_get_chars" [drivers/char/hvcs.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Regards--
Subrata
On Thu, Apr 09, 2009 at 10:31:12AM -0400, Josh Boyer wrote:
> On Thu, Apr 09, 2009 at 09:28:23AM -0500, Kumar Gala wrote:
> >
> > On Apr 9, 2009, at 8:52 AM, Subrata Modak wrote:
> >
> >> Observed the following build error:
> >>
> >> CC drivers/net/ibm_newemac/core.o
> >> drivers/net/ibm_newemac/core.c: In function ???emac_probe???:
> >> drivers/net/ibm_newemac/core.c:2831: error: ???struct net_device??? has no
> >> member named ???open???
> >> drivers/net/ibm_newemac/core.c:2834: error: ???struct net_device??? has no
> >> member named ???tx_timeout???
> >> drivers/net/ibm_newemac/core.c:2836: error: ???struct net_device??? has no
> >> member named ???stop???
> >> drivers/net/ibm_newemac/core.c:2837: error: ???struct net_device??? has no
> >> member named ???get_stats???
> >> drivers/net/ibm_newemac/core.c:2838: error: ???struct net_device??? has no
> >> member named ???set_multicast_list???
> >> drivers/net/ibm_newemac/core.c:2839: error: ???struct net_device??? has no
> >> member named ???do_ioctl???
> >> drivers/net/ibm_newemac/core.c:2841: error: ???struct net_device??? has no
> >> member named ???hard_start_xmit???
> >> drivers/net/ibm_newemac/core.c:2842: error: ???struct net_device??? has no
> >> member named ???change_mtu???
> >> drivers/net/ibm_newemac/core.c:2845: error: ???struct net_device??? has no
> >> member named ???hard_start_xmit???
> >> make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1
> >> make[2]: *** [drivers/net/ibm_newemac] Error 2
> >> make[1]: *** [drivers/net] Error 2
> >> make: *** [drivers] Error 2
> >>
> >> Regards--
> >> Subrata
> >>
> >> <randconfig4-ppc64-next20090409.txt>
> >
> > This is because CONFIG_COMPAT_NET_DEV_OPS isnt set and needs to be for
> > this driver to build. I've asked the netdev guys about either fixing
> > the driver or adding the proper thing to Kconfig to select
> > CONFIG_COMPAT_NET_DEV_OPS.
>
> Thanks!
>
> If someone has pointers on what needs to be done to fix it, let me know.
>
From: Alexander Beregalov <[email protected]>
Subject: [PATCH] ibm_newemac: convert to netdev_ops
Reported-by: Subrata Modak <[email protected]>
Signed-off-by: Alexander Beregalov <[email protected]>
---
drivers/net/ibm_newemac/core.c | 41 ++++++++++++++++++++++++++++-----------
1 files changed, 29 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 77e4b5b..806533c 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -2686,6 +2686,32 @@ static int __devinit emac_init_config(struct emac_instance *dev)
return 0;
}
+static const struct net_device_ops emac_netdev_ops = {
+ .ndo_open = emac_open,
+ .ndo_stop = emac_close,
+ .ndo_get_stats = emac_stats,
+ .ndo_set_multicast_list = emac_set_multicast_list,
+ .ndo_do_ioctl = emac_ioctl,
+ .ndo_tx_timeout = emac_tx_timeout,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_start_xmit = emac_start_xmit,
+ .ndo_change_mtu = eth_change_mtu,
+};
+
+static const struct net_device_ops emac_gige_netdev_ops = {
+ .ndo_open = emac_open,
+ .ndo_stop = emac_close,
+ .ndo_get_stats = emac_stats,
+ .ndo_set_multicast_list = emac_set_multicast_list,
+ .ndo_do_ioctl = emac_ioctl,
+ .ndo_tx_timeout = emac_tx_timeout,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_start_xmit = emac_start_xmit_sg,
+ .ndo_change_mtu = emac_change_mtu,
+};
+
static int __devinit emac_probe(struct of_device *ofdev,
const struct of_device_id *match)
{
@@ -2827,23 +2853,14 @@ static int __devinit emac_probe(struct of_device *ofdev,
if (err != 0)
goto err_detach_tah;
- /* Fill in the driver function table */
- ndev->open = &emac_open;
if (dev->tah_dev)
ndev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
- ndev->tx_timeout = &emac_tx_timeout;
ndev->watchdog_timeo = 5 * HZ;
- ndev->stop = &emac_close;
- ndev->get_stats = &emac_stats;
- ndev->set_multicast_list = &emac_set_multicast_list;
- ndev->do_ioctl = &emac_ioctl;
if (emac_phy_supports_gige(dev->phy_mode)) {
- ndev->hard_start_xmit = &emac_start_xmit_sg;
- ndev->change_mtu = &emac_change_mtu;
+ ndev->netdev_ops = &emac_gige_netdev_ops;
dev->commac.ops = &emac_commac_sg_ops;
- } else {
- ndev->hard_start_xmit = &emac_start_xmit;
- }
+ } else
+ ndev->netdev_ops = &emac_netdev_ops;
SET_ETHTOOL_OPS(ndev, &emac_ethtool_ops);
netif_carrier_off(ndev);
From: Alexander Beregalov <[email protected]>
Date: Fri, 10 Apr 2009 05:56:14 +0400
> Subject: [PATCH] ibm_newemac: convert to netdev_ops
>
>
> Reported-by: Subrata Modak <[email protected]>
> Signed-off-by: Alexander Beregalov <[email protected]>
Applied.