2009-04-12 10:47:59

by Mariusz Kozlowski

[permalink] [raw]
Subject: [PATCH] balance parentheses and braces

Using rather dumb script I found some unbalanced parentheses and braces
here and there. These patches are trivial and attepmt to fix them.


2009-04-12 10:47:45

by Mariusz Kozlowski

[permalink] [raw]
Subject: [PATCH 1/4] fix parenthesis balance in blackfin arch code


Signed-off-by: Mariusz Kozlowski <[email protected]>
---
arch/blackfin/mach-bf538/include/mach/cdefBF538.h | 2 +-
arch/blackfin/mach-bf548/include/mach/anomaly.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/mach-bf538/include/mach/cdefBF538.h b/arch/blackfin/mach-bf538/include/mach/cdefBF538.h
index 241725b..2a6c71d 100644
--- a/arch/blackfin/mach-bf538/include/mach/cdefBF538.h
+++ b/arch/blackfin/mach-bf538/include/mach/cdefBF538.h
@@ -74,7 +74,7 @@
#define bfin_read_SIC_IWR1() bfin_read32(SIC_IWR1)
#define bfin_write_SIC_IWR1(val) bfin_write32(SIC_IWR1, val)
#define bfin_read_SIC_IWR(x) bfin_read32(SIC_IWR0 + x * (SIC_IWR1 - SIC_IWR0))
-#define bfin_write_SIC_IWR(x, val) bfin_write32((SIC_IWR0 + x * (SIC_IWR1 - SIC_IWR0), val)
+#define bfin_write_SIC_IWR(x, val) bfin_write32(SIC_IWR0 + x * (SIC_IWR1 - SIC_IWR0), val)
#define bfin_read_SIC_IAR0() bfin_read32(SIC_IAR0)
#define bfin_write_SIC_IAR0(val) bfin_write32(SIC_IAR0, val)
#define bfin_read_SIC_IAR1() bfin_read32(SIC_IAR1)
diff --git a/arch/blackfin/mach-bf548/include/mach/anomaly.h b/arch/blackfin/mach-bf548/include/mach/anomaly.h
index 882e40c..b1f9494 100644
--- a/arch/blackfin/mach-bf548/include/mach/anomaly.h
+++ b/arch/blackfin/mach-bf548/include/mach/anomaly.h
@@ -170,7 +170,7 @@
/* Reduced Timing Margins on DDR Output Setup and Hold (tDS and tDH) */
#define ANOMALY_05000449 (__SILICON_REVISION__ == 1)
/* USB DMA Mode 1 Short Packet Data Corruption */
-#define ANOMALY_05000450 (1
+#define ANOMALY_05000450 (1)

/* Anomalies that don't exist on this proc */
#define ANOMALY_05000125 (0)
--
1.5.6.3

2009-04-12 10:48:36

by Mariusz Kozlowski

[permalink] [raw]
Subject: [PATCH 3/4] balance parentheses in dvb stv0900_priv.h code


Signed-off-by: Mariusz Kozlowski <[email protected]>
---
drivers/media/dvb/frontends/stv0900_priv.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/frontends/stv0900_priv.h b/drivers/media/dvb/frontends/stv0900_priv.h
index 762d5af..bbd0697 100644
--- a/drivers/media/dvb/frontends/stv0900_priv.h
+++ b/drivers/media/dvb/frontends/stv0900_priv.h
@@ -60,7 +60,7 @@
} \
} while (0)

-#define dmd_choose(a, b) (demod = STV0900_DEMOD_2 ? b : a))
+#define dmd_choose(a, b) (demod = STV0900_DEMOD_2 ? b : a)

static int stvdebug;

--
1.5.6.3

2009-04-12 10:48:23

by Mariusz Kozlowski

[permalink] [raw]
Subject: [PATCH 2/4] remove unbalanced opening brace from drivers/atm/iphase.c

It's under #ifdef 0 but I think it's worth fixing anyway.

Signed-off-by: Mariusz Kozlowski <[email protected]>
---
drivers/atm/iphase.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 78c9736..dd8c3ec 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -795,7 +795,7 @@ static void ia_hw_type(IADEV *iadev) {
iadev->rx_buf_sz, iadev->rx_pkt_ram);)

#if 0
- if ((memType & FE_MASK) == FE_SINGLE_MODE) {
+ if ((memType & FE_MASK) == FE_SINGLE_MODE)
iadev->phy_type = PHY_OC3C_S;
else if ((memType & FE_MASK) == FE_UTP_OPTION)
iadev->phy_type = PHY_UTP155;
--
1.5.6.3

2009-04-12 10:48:52

by Mariusz Kozlowski

[permalink] [raw]
Subject: [PATCH 4/4] balance parenthesis in sis init301.c code

It's under #ifdef 0 but I think it's worth fixing anyway.

Signed-off-by: Mariusz Kozlowski <[email protected]>
---
drivers/video/sis/init301.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/sis/init301.c b/drivers/video/sis/init301.c
index da33d80..4b61e1b 100644
--- a/drivers/video/sis/init301.c
+++ b/drivers/video/sis/init301.c
@@ -11017,7 +11017,7 @@ SetOEMLCDData(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned short
unsigned char *ROMAddr = SiS_Pr->VirtualRomBase;
unsigned short index,temp;

- if((SiS_Pr->SiS_UseROM) {
+ if (SiS_Pr->SiS_UseROM) {
if(!(ROMAddr[0x237] & 0x01)) return;
if(!(ROMAddr[0x237] & 0x04)) return;
/* No rom pointer in BIOS header! */
--
1.5.6.3

2009-04-12 12:22:26

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] balance parentheses and braces

On Sun, Apr 12, 2009 at 12:47:27PM +0200, Mariusz Kozlowski wrote:
> Using rather dumb script I found some unbalanced parentheses and braces
> here and there. These patches are trivial and attepmt to fix them.

I suggest you put some effort into finding the relevant receivers for these patches.
This way they are more likely to be picked up and applied.

If you really do not know who to send them too try to send them to Andrew Morton.

Sam

2009-04-12 16:19:03

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] balance parentheses and braces

On Sun, 12 Apr 2009 14:24:19 +0200
Sam Ravnborg <[email protected]> wrote:

> On Sun, Apr 12, 2009 at 12:47:27PM +0200, Mariusz Kozlowski wrote:
> > Using rather dumb script I found some unbalanced parentheses and braces
> > here and there. These patches are trivial and attepmt to fix them.
>
> I suggest you put some effort into finding the relevant receivers for these patches.
> This way they are more likely to be picked up and applied.
>
> If you really do not know who to send them too try to send them to Andrew Morton.

Allright. I just figured they are too trivial to bother too many people and someone
would pick them all at once.

Mariusz

2009-04-12 18:22:20

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] balance parentheses and braces

On Sun, 2009-04-12 at 14:24 +0200, Sam Ravnborg wrote:
> I suggest you put some effort into finding the relevant receivers for these patches.
> This way they are more likely to be picked up and applied.

Or using the MAINTAINER patches and script I sent
and very little effort:

Without recent git-signers:

$ ./scripts/get_maintainer.pl -f --no-git arch/blackfin/mach-bf538/include/mach/cdefBF538.h
[email protected]
Bryan Wu <[email protected]>
$ ./scripts/get_maintainer.pl -f --no-git arch/blackfin/mach-bf548/include/mach/anomaly.h
[email protected]
Bryan Wu <[email protected]>
$ ./scripts/get_maintainer.pl -f --no-git drivers/atm/iphase.c
[email protected]
Chas Williams <[email protected]>
$ ./scripts/get_maintainer.pl -f --no-git drivers/media/dvb/frontends/stv0900_priv.h
[email protected]
Mauro Carvalho Chehab <[email protected]>
$ ./scripts/get_maintainer.pl -f --no-git drivers/video/sis/init301.c
Thomas Winischhofer <[email protected]>

or with recent git-signers:

$ ./scripts/get_maintainer.pl -f arch/blackfin/mach-bf538/include/mach/cdefBF538.h
[email protected]
Bryan Wu <[email protected]>
Mike Frysinger <[email protected]>
Yi Li <[email protected]>
Michael Hennerich <[email protected]>
$ ./scripts/get_maintainer.pl -f arch/blackfin/mach-bf548/include/mach/anomaly.h
[email protected]
Bryan Wu <[email protected]>
Mike Frysinger <[email protected]>
Robin Getz <[email protected]>
$ ./scripts/get_maintainer.pl -f drivers/atm/iphase.c
[email protected]
Chas Williams <[email protected]>
David S. Miller <[email protected]>
"Jorge Boncompte [DTI2]" <[email protected]>
Andrew Morton <[email protected]>
Wu Fengguang <[email protected]>
$ ./scripts/get_maintainer.pl -f drivers/media/dvb/frontends/stv0900_priv.h
[email protected]
Mauro Carvalho Chehab <[email protected]>
Mauro Carvalho Chehab <[email protected]>
Randy Dunlap <[email protected]>
Igor M. Liplianin <[email protected]>
Andrew Morton <[email protected]>
$ ./scripts/get_maintainer.pl -f drivers/video/sis/init301.c
Thomas Winischhofer <[email protected]>