2009-04-13 15:21:44

by Christoph Hellwig

[permalink] [raw]
Subject: [PATCH] add ptrace entry to MAINTAINERS

At the LF collab summit we decided to make Roland official ptrace
maintainer not just the defacto one he has been for a couple of years
now.

Signed-off-by: Christoph Hellwig <[email protected]>

Index: linux-2.6/MAINTAINERS
===================================================================
--- linux-2.6.orig/MAINTAINERS 2009-04-13 17:17:16.907949256 +0200
+++ linux-2.6/MAINTAINERS 2009-04-13 17:18:35.028962859 +0200
@@ -3597,6 +3597,12 @@ M: [email protected]
L: [email protected]
S: Maintained

+PTRACE SUPPORT
+P: Roland McGrath
+M: [email protected]
+L: [email protected]
+S: Maintained
+
PVRUSB2 VIDEO4LINUX DRIVER
P: Mike Isely
M: [email protected]


2009-04-14 00:31:59

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] add ptrace entry to MAINTAINERS

On Mon, 2009-04-13 at 17:20 +0200, Christoph Hellwig wrote:
> At the LF collab summit we decided to make Roland official ptrace
> maintainer not just the defacto one he has been for a couple of years
> now.
>
> Signed-off-by: Christoph Hellwig <[email protected]>

After a couple of emails with Roland,
now with file patterns...

Signed-off-by: Joe Perches <[email protected]>

diff --git a/MAINTAINERS b/MAINTAINERS
index 29d74f4..df42699 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4448,6 +4448,21 @@ M: [email protected]
L: [email protected]
S: Maintained

+PTRACE SUPPORT
+P: Roland McGrath
+M: [email protected]
+L: [email protected]
+S: Maintained
+F: arch/x86/*/ptrace*
+F: arch/x86/*/*/ptrace*
+F: arch/powerpc/*/ptrace*
+F: arch/powerpc/*/*/ptrace*
+F: include/asm-generic/syscall.h
+F: include/linux/ptrace.h
+F: include/linux/regset.h
+F: include/linux/tracehook.h
+F: kernel/ptrace.c
+
PVRUSB2 VIDEO4LINUX DRIVER
P: Mike Isely
M: [email protected]

2009-04-14 00:43:16

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] add ptrace entry to MAINTAINERS


* Christoph Hellwig <[email protected]> wrote:

> At the LF collab summit we decided to make Roland official ptrace
> maintainer not just the defacto one he has been for a couple of years
> now.
>
> Signed-off-by: Christoph Hellwig <[email protected]>

Hm, what is this "LF collab summit" that makes decisions in terms of
who maintains what? Some new buerocracy on top of Linux i have not
heard about yet? :)

Because you got your facts wrong: the real ptrace de-facto
maintainer is Oleg Nesterov and Andrew Morton, as per
kernel/ptrace.c and arch/x86/kernel/ptrace.c signoffs since v2.6.27:

2 Tejun Heo
2 WANG Cong
3 Roland McGrath
4 David Howells
5 James Morris
6 Oleg Nesterov
7 Andrew Morton
9 Linus Torvalds
9 Markus Metzger
22 Ingo Molnar

Oleg has been doing most of the heavy lifting in terms of reviewing
patches, acking patches and most importantly: keeping bad patches
out of the ptrace code - in the past year or so.

Although i would certainly not mind Roland getting more active in
this space either :)

But in terms of fairness, if you so conveniently 'decide' who
maintains ptrace then Oleg is a must-have maintainer in that space
too.

Ingo

2009-04-14 01:16:33

by Roland McGrath

[permalink] [raw]
Subject: Re: [PATCH] add ptrace entry to MAINTAINERS

Oleg and I certainly consistently work together on this stuff, always CC
each other, and will continue to stay in constant contact wrt all this
code. Since we work happily together, I don't think either of us is
especially interested in defining who is most "active" or "authoritative"
in the space. (Of course Oleg can speak for himself.) The recent Linux
Foundation event was the place where Christoph and I were together to
discuss what might be on the horizon for all this stuff. Christoph
suggested the MAINTAINERS addition there, and I did not object. (I
already feel obliged to review all the patches in practice and have long
since given up any plausible deniability on that, so being explicitly
named for it is not a whole lot worse.)


Thanks,
Roland

2009-04-14 01:27:52

by Oleg Nesterov

[permalink] [raw]
Subject: Re: [PATCH] add ptrace entry to MAINTAINERS

I'd be happy to be counted as a co-maintainer. I mean, I'd like to see
the emails about the ptrace-related problems.

But, the "real" maintainer is Roland. Not only he knows indefinitely more
about ptrace. He knows _why_ the code does this and that, and how it should
evolve.

Sometimes I am able to reply faster, but I always rely on his final verdict.

Oleg.

2009-04-14 02:19:25

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] add ptrace entry to MAINTAINERS

On Tue, 2009-04-14 at 02:42 +0200, Ingo Molnar wrote:
> * Christoph Hellwig <[email protected]> wrote:
>
> > At the LF collab summit we decided to make Roland official ptrace
> > maintainer not just the defacto one he has been for a couple of years
> > now.
> >
> > Signed-off-by: Christoph Hellwig <[email protected]>
>
> Hm, what is this "LF collab summit" that makes decisions in terms of
> who maintains what? Some new buerocracy on top of Linux i have not
> heard about yet? :)

I think the MAINTAINERS file could
use a new status type.

These are the status types today:

Supported: Someone is actually paid to look after this.
Maintained: Someone actually looks after it.
Odd Fixes: It has a maintainer but they don't have time to do
much other than throw the odd patch in. See below..
Orphan: No current maintainer [but maybe you could take the
role as you write your new code].
Obsolete: Old code. Something tagged obsolete generally means
it has been replaced by a better system and you
should be using that.

Maybe it'd be useful to have a defined
aggregator/overseer/gatekeeper role.

Basically what Greg Kroah-Hartman does for staging
and David Miller does for driver/net