2009-04-14 18:33:04

by Subrata Modak

[permalink] [raw]
Subject: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]

Observed the following build error:
---
CC [M] drivers/ide/pmac.o
drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
drivers/ide/pmac.c:955: error: implicit declaration of function
‘check_media_bay_by_base’
drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’:
drivers/ide/pmac.c:1090: error: implicit declaration of function
‘media_bay_set_ide_infos’
make[2]: *** [drivers/ide/pmac.o] Error 1
make[1]: *** [drivers/ide] Error 2
make: *** [drivers] Error 2
---

Regards--
Subrata

Attachments:
randconfig7-next20090414-ppc64 (55.40 kB)

2009-04-14 20:07:52

by Greg KH

[permalink] [raw]
Subject: Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]

On Tue, Apr 14, 2009 at 11:59:19PM +0530, Subrata Modak wrote:
> Observed the following build error:

<snip>

I have no objection on being cc:ed on errors that have something to do
with stuff I maintain, but on areas I don't maintain, it just ends up as
noise in my already-overflowing inbox...

thanks,

greg k-h

Subject: Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]

On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> ‘check_media_bay_by_base’
> drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> ‘media_bay_set_ide_infos’
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---

Should be fixed by:

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] ide-pmac: fix modular build for CONFIG_PMAC_MEDIABAY=y

On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> ‘check_media_bay_by_base’
> drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> ‘media_bay_set_ide_infos’
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---

IDE PMAC host driver can be modular now so we need to export
check_media_bay_by_base() and media_bay_set_ide_infos().

Reported-by: Subrata Modak <[email protected]>
Cc: Paul Mackerras <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
---
drivers/macintosh/mediabay.c | 2 ++
1 file changed, 2 insertions(+)

Index: b/drivers/macintosh/mediabay.c
===================================================================
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -447,6 +447,7 @@ int check_media_bay_by_base(unsigned lon

return -ENODEV;
}
+EXPORT_SYMBOL_GPL(check_media_bay_by_base);

int media_bay_set_ide_infos(struct device_node* which_bay, unsigned long base,
int irq, ide_hwif_t *hwif)
@@ -486,6 +487,7 @@ int media_bay_set_ide_infos(struct devic

return -ENODEV;
}
+EXPORT_SYMBOL_GPL(media_bay_set_ide_infos);
#endif /* CONFIG_BLK_DEV_IDE_PMAC */

static void media_bay_step(int i)