2009-04-16 14:46:18

by Alexander Beregalov

Subject: [PATCH] parisc/superio: fix build breakage

Usage of parport_pc_probe_port was changed in 28783eb52
(parport: Fix various uses of parport_pc).

It introduced this build error:
drivers/parisc/superio.c: In function 'superio_parport_init':
drivers/parisc/superio.c:437: error: too few arguments to function
'parport_pc_probe_port'

Fix it.

Signed-off-by: Alexander Beregalov <[email protected]>
---
drivers/parisc/superio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c
index 33e5ade..9ab9796 100644
--- a/drivers/parisc/superio.c
+++ b/drivers/parisc/superio.c
@@ -434,8 +434,8 @@ static void __init superio_parport_init(void)
0 /*base_hi*/,
PAR_IRQ,
PARPORT_DMA_NONE /* dma */,
- NULL /*struct pci_dev* */),
- 0 /* shared irq flags */ )
+ NULL /*struct pci_dev* */,
+ 0 /* shared irq flags */))

printk(KERN_WARNING PFX "Probing parallel port failed.\n");
#endif /* CONFIG_PARPORT_PC */
--
1.6.2.3

2009-04-16 16:14:48

by Kyle McMartin

Subject: Re: [PATCH] parisc/superio: fix build breakage

On Thu, Apr 16, 2009 at 06:45:59PM +0400, Alexander Beregalov wrote:
> Usage of parport_pc_probe_port was changed in 28783eb52
> (parport: Fix various uses of parport_pc).
>
> It introduced this build error:
> drivers/parisc/superio.c: In function 'superio_parport_init':
> drivers/parisc/superio.c:437: error: too few arguments to function
> 'parport_pc_probe_port'
>
> Fix it.
>
> Signed-off-by: Alexander Beregalov <[email protected]>

Hi Alexander,

Wei Yongjun sent this patch in a few days ago, and I've applied it, but
it appears I forgot to update patchwork or push out the fixes branch.

Cheers, Kyle