2009-04-26 13:38:59

by Tobias Klauser

Subject: [PATCH] staging - pohmelfs: Storage class should be before const qualifier

The C99 specification states in section 6.11.5:

The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.

Signed-off-by: Tobias Klauser <[email protected]>
---
drivers/staging/pohmelfs/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
index b2eaf90..779445e 100644
--- a/drivers/staging/pohmelfs/inode.c
+++ b/drivers/staging/pohmelfs/inode.c
@@ -943,7 +943,7 @@ err_out_unlock:
return ret;
}

-const static struct file_operations pohmelfs_file_ops = {
+static const struct file_operations pohmelfs_file_ops = {
.open = generic_file_open,
.fsync = pohmelfs_fsync,

--
1.6.2.4

2009-04-26 18:01:50

by Evgeniy Polyakov

Subject: Re: [PATCH] staging - pohmelfs: Storage class should be before const qualifier

On Sun, Apr 26, 2009 at 03:06:09PM +0200, Tobias Klauser ([email protected]) wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <[email protected]>

Looks good, thank you.
Greg, please put it into the queue.

> ---
> drivers/staging/pohmelfs/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
> index b2eaf90..779445e 100644
> --- a/drivers/staging/pohmelfs/inode.c
> +++ b/drivers/staging/pohmelfs/inode.c
> @@ -943,7 +943,7 @@ err_out_unlock:
> return ret;
> }
>
> -const static struct file_operations pohmelfs_file_ops = {
> +static const struct file_operations pohmelfs_file_ops = {
> .open = generic_file_open,
> .fsync = pohmelfs_fsync,
>
> --
> 1.6.2.4

--
Evgeniy Polyakov