2009-04-26 08:50:29

by Mike Rapoport

Subject: [PATCH] regulator/virtual: fix strings compare predicates

Signed-off-by: Mike Rapoport <[email protected]>
---
drivers/regulator/virtual.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
index 3d08348..71403fa 100644
--- a/drivers/regulator/virtual.c
+++ b/drivers/regulator/virtual.c
@@ -230,13 +230,13 @@ static ssize_t set_mode(struct device *dev, struct device_attribute *attr,
* sysfs_streq() doesn't need the \n's, but we add them so the strings
* will be shared with show_mode(), above.
*/
- if (sysfs_streq(buf, "fast\n") == 0)
+ if (sysfs_streq(buf, "fast\n"))
mode = REGULATOR_MODE_FAST;
- else if (sysfs_streq(buf, "normal\n") == 0)
+ else if (sysfs_streq(buf, "normal\n"))
mode = REGULATOR_MODE_NORMAL;
- else if (sysfs_streq(buf, "idle\n") == 0)
+ else if (sysfs_streq(buf, "idle\n"))
mode = REGULATOR_MODE_IDLE;
- else if (sysfs_streq(buf, "standby\n") == 0)
+ else if (sysfs_streq(buf, "standby\n"))
mode = REGULATOR_MODE_STANDBY;
else {
dev_err(dev, "Configuring invalid mode\n");
--
1.5.6.4

2009-04-26 09:47:40

by Mark Brown

Subject: Re: [PATCH] regulator/virtual: fix strings compare predicates

On Sun, Apr 26, 2009 at 11:49:30AM +0300, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <[email protected]>

Good catch, thanks.

Acked-by: Mark Brown <[email protected]>

2009-04-27 11:40:58

by Liam Girdwood

Subject: Re: [PATCH] regulator/virtual: fix strings compare predicates

On Sun, 2009-04-26 at 11:49 +0300, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> drivers/regulator/virtual.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>

Applied.

Thanks

Liam