2009-04-28 11:58:18

by Amit Kucheria

Subject: [PATCH] Quirk for BT USB device on MacbookPro to be reset before use

From: Amit Kucheria <[email protected]>

Reset the Bluetooth device on Macbook Pro 5.1 inorder to be able to use it

Bug: #332443
BugLink: https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/332443

Signed-off-by: Amit Kucheria <[email protected]>
---
drivers/bluetooth/btusb.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 7a29a2b..c017cc5 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -109,6 +109,9 @@ static struct usb_device_id blacklist_table[] = {
/* Apple MacBook Pro with Broadcom chip */
{ USB_DEVICE(0x05ac, 0x820f), .driver_info = BTUSB_RESET },

+ /* Apple MacBook Pro 5,1 */
+ { USB_DEVICE(0x05ac, 0x8213), .driver_info = BTUSB_RESET },
+
/* IBM/Lenovo ThinkPad with Broadcom chip */
{ USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
{ USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
--
1.6.0.4

2009-04-28 13:43:00

by Marcel Holtmann

Subject: Re: [PATCH] Quirk for BT USB device on MacbookPro to be reset before use

Hi Amit,

> From: Amit Kucheria <[email protected]>
>
> Reset the Bluetooth device on Macbook Pro 5.1 inorder to be able to use it
>
> Bug: #332443
> BugLink: https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/332443
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 7a29a2b..c017cc5 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -109,6 +109,9 @@ static struct usb_device_id blacklist_table[] = {
> /* Apple MacBook Pro with Broadcom chip */
> { USB_DEVICE(0x05ac, 0x820f), .driver_info = BTUSB_RESET },
>
> + /* Apple MacBook Pro 5,1 */
> + { USB_DEVICE(0x05ac, 0x8213), .driver_info = BTUSB_RESET },
> +

can you guys please NOT send out blindly outdated patches from your
vendor kernel. Check if patches apply to Linus' kernel first and that
they still make sense. In this case I have changed the BTUSB_RESET logic
as default and marked the few old/broken devices as exception.

Regards

Marcel

2009-04-29 06:17:55

by Amit Kucheria

Subject: Re: [PATCH] Quirk for BT USB device on MacbookPro to be reset before use

On Tue, Apr 28, 2009 at 06:42:46AM -0700, Marcel Holtmann wrote:
>
> can you guys please NOT send out blindly outdated patches from your
> vendor kernel. Check if patches apply to Linus' kernel first and that
> they still make sense. In this case I have changed the BTUSB_RESET logic
> as default and marked the few old/broken devices as exception.

I stand suitably rebuked for good reason. Apologies. I will try not to repeat this mistake.

Regards,
Amit

--
------------------------------------------------------------
Amit Kucheria, Finland
------------------------------------------------------------