2009-06-14 21:32:09

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH -rt] include linux/delay.h in hwlat_detector

This broke when compiling on i386 without X86_LOCAL_APIC because then
arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
linux/delay.h.

Signed-off-by: Uwe Kleine-König <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Jon Masters <[email protected]>
---

diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
index dbd9661..e02d8e1 100644
--- a/drivers/misc/hwlat_detector.c
+++ b/drivers/misc/hwlat_detector.c
@@ -49,6 +49,7 @@
#include <linux/seq_file.h>
#include <linux/uaccess.h>
#include <linux/version.h>
+#include <linux/delay.h>

#define BUF_SIZE_DEFAULT 262144UL /* 8K*(sizeof(entry)) */
#define BUF_FLAGS (RB_FL_OVERWRITE) /* no block on full */


2009-06-15 00:54:58

by Jon Masters

[permalink] [raw]
Subject: Re: [PATCH -rt] include linux/delay.h in hwlat_detector

On Sun, 2009-06-14 at 23:31 +0200, Uwe Kleine-König wrote:
> This broke when compiling on i386 without X86_LOCAL_APIC because then
> arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
> linux/delay.h.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Jon Masters <[email protected]>
> ---

Oh, thanks. I will also look at better handling hotplug CPU just to make
Paul happy (probably just disable on hotplug as you'll need to restart
any testing then), though as he said, it's obvious one shouldn't be
removing CPUs at the same time as benchmarking.

Jon.