2009-06-15 19:01:20

by Mark Brown

Subject: [PATCH] regulator: Report regulator_get() failure in virtual consumer

The core will no longer complain so we should log an error here.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/virtual.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
index e7db566..e953c18 100644
--- a/drivers/regulator/virtual.c
+++ b/drivers/regulator/virtual.c
@@ -285,6 +285,8 @@ static int regulator_virtual_consumer_probe(struct platform_device *pdev)
drvdata->regulator = regulator_get(&pdev->dev, reg_id);
if (IS_ERR(drvdata->regulator)) {
ret = PTR_ERR(drvdata->regulator);
+ dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
+ reg_id, ret);
goto err;
}

--
1.6.3.1

2009-06-16 09:16:29

by Liam Girdwood

Subject: Re: [PATCH] regulator: Report regulator_get() failure in virtual consumer

On Mon, 2009-06-15 at 20:01 +0100, Mark Brown wrote:
> The core will no longer complain so we should log an error here.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/virtual.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
> index e7db566..e953c18 100644
> --- a/drivers/regulator/virtual.c
> +++ b/drivers/regulator/virtual.c
> @@ -285,6 +285,8 @@ static int regulator_virtual_consumer_probe(struct platform_device *pdev)
> drvdata->regulator = regulator_get(&pdev->dev, reg_id);
> if (IS_ERR(drvdata->regulator)) {
> ret = PTR_ERR(drvdata->regulator);
> + dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
> + reg_id, ret);
> goto err;
> }
>

Applied.

Thanks

Liam