2009-06-18 13:37:41

by Steven Rostedt

Subject: Re: [PATCH 6/9 UPDATED] percpu: enforce global definition

On Thu, 2009-06-18 at 16:38 +0900, Tejun Heo wrote:
> Some archs (alpha and s390) need to add 'weak' attribute to percpu
> variable definitions so that the compiler generates external
> references for them. To allow this, enforce global definition of all
> percpu variables.
>
> This patch makes DEFINE_PER_CPU_SECTION() do DECLARE_PERCPU_SECTION()
> implicitly and drop static from all percpu definitions.
>
> [ Impact: all percpu variables are forced to be global ]
>
> Signed-off-by: Tejun Heo <[email protected]>
> Reviewed-by: Christoph Lameter <[email protected]>
> Acked-by: Paul E. McKenney <[email protected]>

Uh, wont this cause name space collisions?

-- Steve

2009-06-18 13:52:25

by Christoph Lameter

Subject: Re: [PATCH 6/9 UPDATED] percpu: enforce global definition

On Thu, 18 Jun 2009, Steven Rostedt wrote:

> Uh, wont this cause name space collisions?

There was an earlier cleanup patch that deal with potential collisions.