2009-06-18 11:24:21

by Jaswinder Singh Rajput

Subject: [PATCH -tip][KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static

toggle_interruptibility() is used only by same file, it should be static.

Fixed following sparse warning :

arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kvm/x86_emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index c1b6c23..616de46 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
return 0;
}

-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
{
u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
/*
--
1.6.0.6

2009-06-20 07:49:18

by Jaswinder Singh Rajput

Subject: [KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static

toggle_interruptibility() is used only by same file, it should be static.

Fixed following sparse warning :

arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kvm/x86_emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index c1b6c23..616de46 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
return 0;
}

-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
{
u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
/*
--
1.6.0.6

2009-06-21 12:47:30

by Avi Kivity

Subject: Re: [PATCH -tip][KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static

On 06/18/2009 02:23 PM, Jaswinder Singh Rajput wrote:
> toggle_interruptibility() is used only by same file, it should be static.
>
> Fixed following sparse warning :
>
> arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
>

Applied, thanks.

--
error compiling committee.c: too many arguments to function