2009-07-01 12:22:34

by Jaswinder Singh Rajput

Subject: [PATCH -tip RESEND] x86: mm/init.c declare check_efer() before it get used

check_efer() is already declared in asm/proto.h, so include it before using it.

Also fix sparse warning :

CHECK arch/x86/mm/init.c
arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 1043590..d31f9e7 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>

DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);

--
1.6.0.6

2009-07-01 14:04:55

by Jaswinder Singh Rajput

Subject: Re: [PATCH -tip RESEND] x86: mm/init.c declare check_efer() before it get used

On Wed, 2009-07-01 at 17:51 +0530, Jaswinder Singh Rajput wrote:
> check_efer() is already declared in asm/proto.h, so include it before using it.
>
> Also fix sparse warning :
>
> CHECK arch/x86/mm/init.c
> arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---

[PATCH] x86: mm/init.c declare check_efer() before it get used

This sparse warning:

arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?

triggers because check_efer() is not decalared before using it.
asm/proto.h includes the declaration of check_efer(), so including asm/proto.h to fix that - this also address the sparse warning.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 47ce9a2..0607119 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>

DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);

--
1.6.0.6