2009-07-01 13:27:05

by Subrata Modak

[permalink] [raw]
Subject: Re: [patch] buildfix ppc randconfig

Greg/David,

Has this been checked in? I am not sure if i know this.

Regards--
Subrata

On Fri, 2009-06-19 at 05:35 -0700, David Brownell wrote:
> From: Arnd Bergmann <[email protected]>
>
> We could just make the USB_OHCI_HCD_PPC_OF option implicit
> and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE
> and USB_OHCI_HCD_PPC_OF_LE are set.
>
> [ [email protected]: fix patch manglation and dependencies ]
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Tested-by: Subrata Modak <[email protected]>
> Signed-off-by: David Brownell <[email protected]>
> ---
> drivers/usb/host/Kconfig | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -181,26 +181,27 @@ config USB_OHCI_HCD_PPC_SOC
> Enables support for the USB controller on the MPC52xx or
> STB03xxx processor chip. If unsure, say Y.
>
> -config USB_OHCI_HCD_PPC_OF
> - bool "OHCI support for PPC USB controller on OF platform bus"
> - depends on USB_OHCI_HCD && PPC_OF
> - default y
> - ---help---
> - Enables support for the USB controller PowerPC present on the
> - OpenFirmware platform bus.
> -
> config USB_OHCI_HCD_PPC_OF_BE
> - bool "Support big endian HC"
> - depends on USB_OHCI_HCD_PPC_OF
> - default y
> + bool "OHCI support for OF platform bus (big endian)"
> + depends on USB_OHCI_HCD && PPC_OF
> select USB_OHCI_BIG_ENDIAN_DESC
> select USB_OHCI_BIG_ENDIAN_MMIO
> + ---help---
> + Enables support for big-endian USB controllers present on the
> + OpenFirmware platform bus.
>
> config USB_OHCI_HCD_PPC_OF_LE
> - bool "Support little endian HC"
> - depends on USB_OHCI_HCD_PPC_OF
> - default n
> + bool "OHCI support for OF platform bus (little endian)"
> + depends on USB_OHCI_HCD && PPC_OF
> select USB_OHCI_LITTLE_ENDIAN
> + ---help---
> + Enables support for little-endian USB controllers present on the
> + OpenFirmware platform bus.
> +
> +config USB_OHCI_HCD_PPC_OF
> + bool
> + depends on USB_OHCI_HCD && PPC_OF
> + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
>
> config USB_OHCI_HCD_PCI
> bool "OHCI support for PCI-bus USB controllers"


2009-07-01 18:06:41

by David Brownell

[permalink] [raw]
Subject: Re: [patch] buildfix ppc randconfig

On Wednesday 01 July 2009, Subrata Modak wrote:
> Greg/David,
>
> Has this been checked in? I am not sure if i know this.

It seems not to be in Greg's "gregkh-02-usb.current"
quilt queue. If Greg's not got near-future cycles
to get USB patches upstream, maybe this can merge
sooner through the PPC tree.

- Dave


> Regards--
> Subrata
>
> On Fri, 2009-06-19 at 05:35 -0700, David Brownell wrote:
> > From: Arnd Bergmann <[email protected]>
> >
> > We could just make the USB_OHCI_HCD_PPC_OF option implicit
> > and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE
> > and USB_OHCI_HCD_PPC_OF_LE are set.
> >
> > [ [email protected]: fix patch manglation and dependencies ]
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > Tested-by: Subrata Modak <[email protected]>
> > Signed-off-by: David Brownell <[email protected]>
> > ---
> > drivers/usb/host/Kconfig | 29 +++++++++++++++--------------
> > 1 file changed, 15 insertions(+), 14 deletions(-)
> >
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -181,26 +181,27 @@ config USB_OHCI_HCD_PPC_SOC
> > Enables support for the USB controller on the MPC52xx or
> > STB03xxx processor chip. If unsure, say Y.
> >
> > -config USB_OHCI_HCD_PPC_OF
> > - bool "OHCI support for PPC USB controller on OF platform bus"
> > - depends on USB_OHCI_HCD && PPC_OF
> > - default y
> > - ---help---
> > - Enables support for the USB controller PowerPC present on the
> > - OpenFirmware platform bus.
> > -
> > config USB_OHCI_HCD_PPC_OF_BE
> > - bool "Support big endian HC"
> > - depends on USB_OHCI_HCD_PPC_OF
> > - default y
> > + bool "OHCI support for OF platform bus (big endian)"
> > + depends on USB_OHCI_HCD && PPC_OF
> > select USB_OHCI_BIG_ENDIAN_DESC
> > select USB_OHCI_BIG_ENDIAN_MMIO
> > + ---help---
> > + Enables support for big-endian USB controllers present on the
> > + OpenFirmware platform bus.
> >
> > config USB_OHCI_HCD_PPC_OF_LE
> > - bool "Support little endian HC"
> > - depends on USB_OHCI_HCD_PPC_OF
> > - default n
> > + bool "OHCI support for OF platform bus (little endian)"
> > + depends on USB_OHCI_HCD && PPC_OF
> > select USB_OHCI_LITTLE_ENDIAN
> > + ---help---
> > + Enables support for little-endian USB controllers present on the
> > + OpenFirmware platform bus.
> > +
> > +config USB_OHCI_HCD_PPC_OF
> > + bool
> > + depends on USB_OHCI_HCD && PPC_OF
> > + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
> >
> > config USB_OHCI_HCD_PCI
> > bool "OHCI support for PCI-bus USB controllers"
>
>

2009-07-01 18:18:02

by Greg KH

[permalink] [raw]
Subject: Re: [patch] buildfix ppc randconfig

On Wed, Jul 01, 2009 at 11:06:23AM -0700, David Brownell wrote:
> On Wednesday 01 July 2009, Subrata Modak wrote:
> > Greg/David,
> >
> > Has this been checked in? I am not sure if i know this.
>
> It seems not to be in Greg's "gregkh-02-usb.current"
> quilt queue. If Greg's not got near-future cycles
> to get USB patches upstream, maybe this can merge
> sooner through the PPC tree.

I think it's in my "to-apply" queue, I've been stuck doing -stable
releases the past few days, so hopefully will have some cycles to get to
these now.

thanks,

greg k-h