2009-07-01 12:16:58

by Jaswinder Singh Rajput

Subject: [PATCH -tip RESEND] x86: ptrace.c ptrace_get_debugreg() should be static

ptrace_get_debugreg() is used only by the same file, so it should be static.

Also fixed sparse warning :

CHECK arch/x86/kernel/ptrace.c
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kernel/ptrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b457f78..cabdabc 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -557,7 +557,7 @@ restore:
/*
* Handle PTRACE_PEEKUSR calls for the debug register area.
*/
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
{
struct thread_struct *thread = &(tsk->thread);
unsigned long val = 0;
--
1.6.0.6

2009-07-01 13:57:03

by Jaswinder Singh Rajput

Subject: Re: [PATCH -tip RESEND] x86: ptrace.c ptrace_get_debugreg() should be static

On Wed, 2009-07-01 at 17:46 +0530, Jaswinder Singh Rajput wrote:
> ptrace_get_debugreg() is used only by the same file, so it should be static.
>
> Also fixed sparse warning :
>
> CHECK arch/x86/kernel/ptrace.c
> arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---

Please apply this :

[PATCH] x86: ptrace ptrace_get_debugreg() should be static

This sparse warning:

arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?

triggers because ptrace_get_debugreg() is global but is only used in a single .c file.
change ptrace_get_debugreg() to static to fix that - this also address the sparse warning.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kernel/ptrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b457f78..cabdabc 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -557,7 +557,7 @@ restore:
/*
* Handle PTRACE_PEEKUSR calls for the debug register area.
*/
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
{
struct thread_struct *thread = &(tsk->thread);
unsigned long val = 0;
--
1.6.0.6