2009-07-07 14:51:21

by John Stoffel

Subject: [PATCH] Make SCSI SG v4 driver enabled by default now since udev depends on it.

Signed-off-by: John Stoffel <[email protected]>
---
block/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index e7d1278..22bf6eb 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -46,8 +46,8 @@ config LBD

config BLK_DEV_BSG
bool "Block layer SG support v4 (EXPERIMENTAL)"
- depends on EXPERIMENTAL
- ---help---
+ default y
+ help
Saying Y here will enable generic SG (SCSI generic) v4 support
for any block device.

@@ -57,7 +57,7 @@ config BLK_DEV_BSG
protocols (e.g. Task Management Functions and SMP in Serial
Attached SCSI).

- If unsure, say N.
+ If unsure, say Y.

config BLK_DEV_INTEGRITY
bool "Block layer data integrity support"
--
1.6.3.3

2009-07-07 15:06:05

by Boaz Harrosh

Subject: Re: [PATCH] Make SCSI SG v4 driver enabled by default now since udev depends on it.

On 07/07/2009 05:50 PM, John Stoffel wrote:
> Signed-off-by: John Stoffel <[email protected]>
> ---
> block/Kconfig | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block/Kconfig b/block/Kconfig
> index e7d1278..22bf6eb 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -46,8 +46,8 @@ config LBD
>
> config BLK_DEV_BSG
> bool "Block layer SG support v4 (EXPERIMENTAL)"

Please also remove the (EXPERIMENTAL) from the prompt as well

> - depends on EXPERIMENTAL
> - ---help---
> + default y
> + help
> Saying Y here will enable generic SG (SCSI generic) v4 support
> for any block device.
>
> @@ -57,7 +57,7 @@ config BLK_DEV_BSG
> protocols (e.g. Task Management Functions and SMP in Serial
> Attached SCSI).
>
> - If unsure, say N.
> + If unsure, say Y.
>
> config BLK_DEV_INTEGRITY
> bool "Block layer data integrity support"

Thanks I needed that too.

BTW distro(s) have been shipping with it on for ages

Boaz

2009-07-07 15:19:21

by John Stoffel

Subject: Re: [PATCH] Make SCSI SG v4 driver enabled by default now since udev depends on it.

>>>>> "Boaz" == Boaz Harrosh <[email protected]> writes:

Boaz> On 07/07/2009 05:50 PM, John Stoffel wrote:
>> Signed-off-by: John Stoffel <[email protected]>
>> ---
>> block/Kconfig | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/block/Kconfig b/block/Kconfig
>> index e7d1278..22bf6eb 100644
>> --- a/block/Kconfig
>> +++ b/block/Kconfig
>> @@ -46,8 +46,8 @@ config LBD
>>
>> config BLK_DEV_BSG
>> bool "Block layer SG support v4 (EXPERIMENTAL)"

Boaz> Please also remove the (EXPERIMENTAL) from the prompt as well

Duh... sorry for this oversight. I'll respin the patch ASAP.

>> - depends on EXPERIMENTAL
>> - ---help---
>> + default y
>> + help
>> Saying Y here will enable generic SG (SCSI generic) v4 support
>> for any block device.
>>
>> @@ -57,7 +57,7 @@ config BLK_DEV_BSG
>> protocols (e.g. Task Management Functions and SMP in Serial
>> Attached SCSI).
>>
>> - If unsure, say N.
>> + If unsure, say Y.
>>
>> config BLK_DEV_INTEGRITY
>> bool "Block layer data integrity support"

Boaz> Thanks I needed that too.

Boaz> BTW distro(s) have been shipping with it on for ages

I ran into this since I was trying to get Udev to properly find and
name my tape drives, and it wasn't until I finally figured out that
BSG wasn't enabled on any of my systems that I got around to getting
it working properly.

I've also put in a patch to the UDEV people to mention that this
should be turned on to make Udev work properly.

John