2014-02-11 20:17:26

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2 11/11] watchdog: xilinx: Remove no_timeout variable

On Tue, Feb 11, 2014 at 07:55:54AM +0100, Michal Simek wrote:
> Remove no_timeout variable and check variables
> directly.
>
> Suggested-by: Rob Herring <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

2014-02-11 20:20:45

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32

On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote:
> Use of_property_read_u32 functions to clean probe function.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
[ ... ]

> +
> + if (enable_once)
> watchdog_set_nowayout(xilinx_wdt_wdd, true);
> - }

watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);

would probably do as well (the function checks the flag as well).

Nitpick, so

Reviewed-by: Guenter Roeck <[email protected]>

2014-02-12 08:13:33

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32

On 02/11/2014 09:20 PM, Guenter Roeck wrote:
> On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote:
>> Use of_property_read_u32 functions to clean probe function.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
> [ ... ]
>
>> +
>> + if (enable_once)
>> watchdog_set_nowayout(xilinx_wdt_wdd, true);
>> - }
>
> watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);
>
> would probably do as well (the function checks the flag as well).
>
> Nitpick, so
>
> Reviewed-by: Guenter Roeck <[email protected]>

I will change it and send v3.

Thanks,
Michal



--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature