I tested 2.6.31 and the mainline amd64_edac driver. This is was the
first simple fix.
This allows the errors to be further decoded and mapped to csrows.
Tested with ECC debug dimms and an Rev F cpu based system.
Submitted-by: Keith Mannthey<[email protected]>
---
diff -urN linux-2.6.31/drivers/edac/amd64_edac.c linux-2.6.31-fixed/drivers/edac/amd64_edac.c
--- linux-2.6.31/drivers/edac/amd64_edac.c 2009-09-09 15:13:59.000000000 -0700
+++ linux-2.6.31-fixed/drivers/edac/amd64_edac.c 2009-09-17 22:32:09.000000000 -0700
@@ -1136,7 +1138,7 @@
* different from the node that detected the error.
*/
src_mci = find_mc_by_sys_addr(mci, SystemAddress);
- if (src_mci) {
+ if (!src_mci) {
amd64_mc_printk(mci, KERN_ERR,
"failed to map error address 0x%lx to a node\n",
(unsigned long)SystemAddress);
Hi Keith,
On Thu, Sep 17, 2009 at 07:09:39PM -0700, Keith Mannthey wrote:
> I tested 2.6.31 and the mainline amd64_edac driver. This is was the
> first simple fix.
>
> This allows the errors to be further decoded and mapped to csrows.
> Tested with ECC debug dimms and an Rev F cpu based system.
>
> Submitted-by: Keith Mannthey<[email protected]>
Thanks, applied. By the way, the tagging is not 'Submitted-by' but
'Signed-off-by' - I've corrected it accordingly. Please consult
<Documentation/SubmittingPatches> for more details on how to prepare
your patches.
> ---
>
> diff -urN linux-2.6.31/drivers/edac/amd64_edac.c linux-2.6.31-fixed/drivers/edac/amd64_edac.c
Add the -p option when creating the diffs so that it is visible which
function you're editing.
> --- linux-2.6.31/drivers/edac/amd64_edac.c 2009-09-09 15:13:59.000000000 -0700
> +++ linux-2.6.31-fixed/drivers/edac/amd64_edac.c 2009-09-17 22:32:09.000000000 -0700
> @@ -1136,7 +1138,7 @@
> * different from the node that detected the error.
> */
> src_mci = find_mc_by_sys_addr(mci, SystemAddress);
> - if (src_mci) {
> + if (!src_mci) {
> amd64_mc_printk(mci, KERN_ERR,
> "failed to map error address 0x%lx to a node\n",
> (unsigned long)SystemAddress);
>
>
>
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. M?nchen, Germany
Research | Gesch?ftsf?hrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis M?nchen
(OSRC) | Registergericht M?nchen, HRB Nr. 43632