2009-09-19 07:43:03

by Nick Gasson

Subject: [PATCH] Fix fn-key release events for Samsung Q320 laptop

This adds a workaround for the missing fn-key release
events on Samsung Q320 and similar laptops.

Tested extensively on my own laptop.

Signed-off-by: Nick Gasson <[email protected]>
---
drivers/input/keyboard/atkbd.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index c9523e4..56a6ffa 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1630,6 +1630,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
.driver_data = atkbd_samsung_forced_release_keys,
},
{
+ .ident = "Samsung Q320/P320",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Q320/P320"),
+ },
+ .callback = atkbd_setup_forced_release,
+ .driver_data = atkbd_samsung_forced_release_keys,
+ },
+ {
.ident = "Samsung SQ45S70S",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
--
1.6.4.1

2009-09-19 13:21:03

by Daniel Walker

Subject: Re: [PATCH] Fix fn-key release events for Samsung Q320 laptop

On Sat, 2009-09-19 at 08:20 +0100, Nick Gasson wrote:
> This adds a workaround for the missing fn-key release
> events on Samsung Q320 and similar laptops.
>
> Tested extensively on my own laptop.
>
> Signed-off-by: Nick Gasson <[email protected]>
> ---
> drivers/input/keyboard/atkbd.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index c9523e4..56a6ffa 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1630,6 +1630,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
> .driver_data = atkbd_samsung_forced_release_keys,
> },
> {
> + .ident = "Samsung Q320/P320",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),

Your patch is whitespace damaged .. All the tabs have been removed from
your code, and the context code in the patch. That usually means the
patch can't be applied .. It can happen when you X copy&paste the patch
into an email. I'd use git-format-patch and git-send-email (since your
using git anyway..)

Daniel

2009-09-19 20:37:54

by Dmitry Torokhov

Subject: Re: [PATCH] Fix fn-key release events for Samsung Q320 laptop

Hi Nick,

On Sep 19, 2009, at 12:20 AM, Nick Gasson <[email protected]> wrote:

> This adds a workaround for the missing fn-key release
> events on Samsung Q320 and similar laptops.
>
> Tested extensively on my own laptop.
>
> Signed-off-by: Nick Gasson <[email protected]>

Thank you very much for your patch, hovewer I will not be accepting
any more patches for the force release quirk in the kernel. 2.6.32
will have 'force_release' sysfs attribute allowing to apply the quirk
from userspace.

--
Dmitry