2009-09-19 10:43:31

by Sebastian Frei

Subject: [PATCH] wistron_btns.c: Add DMI entry for Medion WIM2030 laptop

This patch adds a DMI entry for the Medion WIM2030 laptop.

Signed-off-by: Sebastian Frei <[email protected]>

--- linux-2.6.31.orig/drivers/input/misc/wistron_btns.c
+++ linux-2.6.31/drivers/input/misc/wistron_btns.c
@@ -669,6 +669,15 @@
},
{
.callback = dmi_matched,
+ .ident = "Medion MD 42200",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Medion"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2030"),
+ },
+ .driver_data = keymap_fs_amilo_pro_v2000
+ },
+ {
+ .callback = dmi_matched,
.ident = "Fujitsu N3510",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),

2009-09-19 13:26:50

by Daniel Walker

Subject: Re: [PATCH] wistron_btns.c: Add DMI entry for Medion WIM2030 laptop

On Sat, 2009-09-19 at 12:43 +0200, Sebastian Frei wrote:
> This patch adds a DMI entry for the Medion WIM2030 laptop.
>
> Signed-off-by: Sebastian Frei <[email protected]>
>
> --- linux-2.6.31.orig/drivers/input/misc/wistron_btns.c
> +++ linux-2.6.31/drivers/input/misc/wistron_btns.c
> @@ -669,6 +669,15 @@
> },
> {
> .callback = dmi_matched,
> + .ident = "Medion MD 42200",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Medion"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2030"),
> + },
> + .driver_data = keymap_fs_amilo_pro_v2000
> + },
> + {
> + .callback = dmi_matched,
> .ident = "Fujitsu N3510",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),

Form email below (your the second person to do this today),

Your patch is whitespace damaged .. All the tabs have been removed from
your code, and the context code in the patch. That usually means the
patch can't be applied .. It can happen when you X copy&paste the patch
into an email. If your using quilt you can use "quilt mail" , or have
your mailer "insert text file" instead of copy&paste.

Daniel

2009-09-19 14:56:17

by Sebastian Frei

Subject: Re: [PATCH] wistron_btns.c: Add DMI entry for Medion WIM2030 laptop

Am Samstag, 19. September 2009 15:26:50 schrieb Daniel Walker:
> On Sat, 2009-09-19 at 12:43 +0200, Sebastian Frei wrote:
> > This patch adds a DMI entry for the Medion WIM2030 laptop.
> >
> > Signed-off-by: Sebastian Frei <[email protected]>
> >
> > --- linux-2.6.31.orig/drivers/input/misc/wistron_btns.c
> > +++ linux-2.6.31/drivers/input/misc/wistron_btns.c
> > @@ -669,6 +669,15 @@
> > },
> > {
> > .callback = dmi_matched,
> > + .ident = "Medion MD 42200",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Medion"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2030"),
> > + },
> > + .driver_data = keymap_fs_amilo_pro_v2000
> > + },
> > + {
> > + .callback = dmi_matched,
> > .ident = "Fujitsu N3510",
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
>
> Form email below (your the second person to do this today),
>
> Your patch is whitespace damaged .. All the tabs have been removed from
> your code, and the context code in the patch. That usually means the
> patch can't be applied .. It can happen when you X copy&paste the patch
> into an email. If your using quilt you can use "quilt mail" , or have
> your mailer "insert text file" instead of copy&paste.
>
> Daniel
>
Next try, this time with tab stops:

Signed-off-by: Sebastian Frei <[email protected]>

--- linux-2.6.31/drivers/input/misc/wistron_btns.c.orig 2008-09-12
20:47:24.000000000 +0200
+++ linux-2.6.31/drivers/input/misc/wistron_btns.c 2008-03-13
22:18:02.000000000 +0100
@@ -669,6 +669,15 @@
},
{
.callback = dmi_matched,
+ .ident = "Medion MD 42200",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Medion"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2030"),
+ },
+ .driver_data = keymap_fs_amilo_pro_v2000
+ },
+ {
+ .callback = dmi_matched,
.ident = "Fujitsu N3510",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),

2009-09-28 17:02:56

by Dmitry Torokhov

Subject: Re: [PATCH] wistron_btns.c: Add DMI entry for Medion WIM2030 laptop

On Sat, Sep 19, 2009 at 04:55:54PM +0200, Sebastian Frei wrote:
> Am Samstag, 19. September 2009 15:26:50 schrieb Daniel Walker:
> > On Sat, 2009-09-19 at 12:43 +0200, Sebastian Frei wrote:
> > > This patch adds a DMI entry for the Medion WIM2030 laptop.
> > >
> > > Signed-off-by: Sebastian Frei <[email protected]>
> > >
> > > --- linux-2.6.31.orig/drivers/input/misc/wistron_btns.c
> > > +++ linux-2.6.31/drivers/input/misc/wistron_btns.c
> > > @@ -669,6 +669,15 @@
> > > },
> > > {
> > > .callback = dmi_matched,
> > > + .ident = "Medion MD 42200",
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "Medion"),
> > > + DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2030"),
> > > + },
> > > + .driver_data = keymap_fs_amilo_pro_v2000
> > > + },
> > > + {
> > > + .callback = dmi_matched,
> > > .ident = "Fujitsu N3510",
> > > .matches = {
> > > DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> >
> > Form email below (your the second person to do this today),
> >
> > Your patch is whitespace damaged .. All the tabs have been removed from
> > your code, and the context code in the patch. That usually means the
> > patch can't be applied .. It can happen when you X copy&paste the patch
> > into an email. If your using quilt you can use "quilt mail" , or have
> > your mailer "insert text file" instead of copy&paste.
> >
> > Daniel
> >
> Next try, this time with tab stops:
>
> Signed-off-by: Sebastian Frei <[email protected]>
>

Applied, thanks Sebastian.

--
Dmitry