2009-09-20 14:22:50

by Krzysztof Halasa

[permalink] [raw]
Subject: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.

A comment fix in drivers/ata/pata_hpt37x.c.

Signed-off-by: Krzysztof Ha?asa <[email protected]>

diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
index 122c786..d0a7df2 100644
--- a/drivers/ata/pata_hpt37x.c
+++ b/drivers/ata/pata_hpt37x.c
@@ -624,7 +624,7 @@ static struct ata_port_operations hpt374_fn1_port_ops = {
};

/**
- * htp37x_clock_slot - Turn timing to PC clock entry
+ * hpt37x_clock_slot - Turn timing to PC clock entry
* @freq: Reported frequency timing
* @base: Base timing
*


2009-09-20 16:35:04

by Daniel Walker

[permalink] [raw]
Subject: Re: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.

On Sun, 2009-09-20 at 16:22 +0200, Krzysztof Halasa wrote:
> A comment fix in drivers/ata/pata_hpt37x.c.
>
> Signed-off-by: Krzysztof Hałasa <[email protected]>
>

checkpatch has some trouble with your name ..

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#42:
Signed-off-by: Krzysztof Haasa <[email protected]>
^

I've seen this warning a few times, and I wasn't sure to exactly what to
do with it.. However, it does seem like a lot of people have trouble
with the encodings ..

I did a little research and I think I was able to produce your name in
utf8 (checkpatch doesn't error any longer..)

Signed-off-by: Krzysztof Hałasa <[email protected]>

Are you aware that your name isn't in utf8? Does the above name look
right to you? To me my version looks identical to your version ..

Daniel

2009-09-20 16:51:57

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.

On Sun, 20 Sep 2009, Krzysztof Halasa wrote:

> A comment fix in drivers/ata/pata_hpt37x.c.
>
> Signed-off-by: Krzysztof Ha?asa <[email protected]>
>
> diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
> index 122c786..d0a7df2 100644
> --- a/drivers/ata/pata_hpt37x.c
> +++ b/drivers/ata/pata_hpt37x.c
> @@ -624,7 +624,7 @@ static struct ata_port_operations hpt374_fn1_port_ops = {
> };
>
> /**
> - * htp37x_clock_slot - Turn timing to PC clock entry
> + * hpt37x_clock_slot - Turn timing to PC clock entry
> * @freq: Reported frequency timing
> * @base: Base timing
> *

Applied to trivial queue, thanks Krzysztof.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-09-20 17:03:49

by Krzysztof Halasa

[permalink] [raw]
Subject: Re: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.

Daniel Walker <[email protected]> writes:

> I did a little research and I think I was able to produce your name in
> utf8 (checkpatch doesn't error any longer..)
>
> Signed-off-by: Krzysztof Hałasa <[email protected]>
>
> Are you aware that your name isn't in utf8? Does the above name look
> right to you? To me my version looks identical to your version ..

Well, it looks like at some point I instructed my Gnus to send in ISO
8859-* encoding if possible. Probably you used the raw "mail spool"
file, instead of converting to UTF-8. Not much surprise, though. There
is no reason for me to use 8859 encodings anymore, I've just switched
that to UTF-8.

Thanks for noticing.
--
Krzysztof Hałasa