2009-09-26 14:12:13

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH] ARM: OMAP: Remove unused CONFIG MACH_OMAP_HTCWIZARD


Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig

Reported-by: Robert P. J. Day <[email protected]>
Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Zebediah C. McClure <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: Kevin Hilman <[email protected]>
Cc: Russell King <[email protected]>
---
arch/arm/mach-omap1/Kconfig | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
index 55ecc01..c25038e 100644
--- a/arch/arm/mach-omap1/Kconfig
+++ b/arch/arm/mach-omap1/Kconfig
@@ -50,12 +50,6 @@ config MACH_OMAP_H3
TI OMAP 1710 H3 board support. Say Y here if you have such
a board.

-config MACH_OMAP_HTCWIZARD
- bool "HTC Wizard"
- depends on ARCH_OMAP850
- help
- HTC Wizard smartphone support (AKA QTEK 9100, ...)
-
config MACH_OMAP_OSK
bool "TI OSK Support"
depends on ARCH_OMAP1 && ARCH_OMAP16XX
--
1.6.0.6


2009-09-27 01:36:09

by Alistair Buxton

[permalink] [raw]
Subject: Re: [PATCH] ARM: OMAP: Remove unused CONFIG MACH_OMAP_HTCWIZARD

2009/9/26 Jaswinder Singh Rajput <[email protected]>:
>
> Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig

Don't do it please! We're working on it.... board file is coming very soon.

--
Alistair Buxton
[email protected]

2009-09-27 01:51:40

by Robert P. J. Day

[permalink] [raw]
Subject: Re: [PATCH] ARM: OMAP: Remove unused CONFIG MACH_OMAP_HTCWIZARD

On Sun, 27 Sep 2009, Alistair Buxton wrote:

> 2009/9/26 Jaswinder Singh Rajput <[email protected]>:
> >
> > Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig
>
> Don't do it please! We're working on it.... board file is coming
> very soon.

i've noticed that happening fairly often -- feature infrastructure
is added before the feature itself. at the risk of sounding all
preachy and everything, that sort of thing should be avoided in order
to keep the history cleaner. and because that's *exactly* the sort of
thing that, occasionally, produces the kind of historical cruft that
leaves unused CONFIG variables lying around when a feature is
abandoned in midstream.

ok, i'll stop preaching now.

rday
--


========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================