2009-09-26 14:01:32

by Jaswinder Singh Rajput

Subject: [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT

Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig

Reported-by: Robert P. J. Day <[email protected]>
Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Byungho Min <[email protected]>
Cc: Ben Dooks <[email protected]>
Cc: Russell King <[email protected]>
---
arch/arm/configs/s5pc100_defconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
index b0d7d3d..94edde5 100644
--- a/arch/arm/configs/s5pc100_defconfig
+++ b/arch/arm/configs/s5pc100_defconfig
@@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
# CONFIG_DEBUG_STACK_USAGE is not set
CONFIG_DEBUG_LL=y
# CONFIG_DEBUG_ICEDCC is not set
-CONFIG_DEBUG_S3C_PORT=y
CONFIG_DEBUG_S3C_UART=0

#
--
1.6.0.6

2009-09-26 14:04:08

by Robert P. J. Day

Subject: Re: [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT

On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:

>
> Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
>
> Reported-by: Robert P. J. Day <[email protected]>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> Cc: Byungho Min <[email protected]>
> Cc: Ben Dooks <[email protected]>
> Cc: Russell King <[email protected]>
> ---
> arch/arm/configs/s5pc100_defconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
> index b0d7d3d..94edde5 100644
> --- a/arch/arm/configs/s5pc100_defconfig
> +++ b/arch/arm/configs/s5pc100_defconfig
> @@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
> # CONFIG_DEBUG_STACK_USAGE is not set
> CONFIG_DEBUG_LL=y
> # CONFIG_DEBUG_ICEDCC is not set
> -CONFIG_DEBUG_S3C_PORT=y
> CONFIG_DEBUG_S3C_UART=0

no, there is no point removing redundant entries from any of the
defconfig files -- those files will eventually be rebuilt
automatically at some point.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================

2009-09-26 15:22:27

by Jaswinder Singh Rajput

Subject: Re: [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT

Hello Robert,

On Sat, 2009-09-26 at 10:03 -0400, Robert P. J. Day wrote:
> On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
>
> >
> > Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
> >
> > Reported-by: Robert P. J. Day <[email protected]>
> > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> > Cc: Byungho Min <[email protected]>
> > Cc: Ben Dooks <[email protected]>
> > Cc: Russell King <[email protected]>
> > ---
> > arch/arm/configs/s5pc100_defconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
> > index b0d7d3d..94edde5 100644
> > --- a/arch/arm/configs/s5pc100_defconfig
> > +++ b/arch/arm/configs/s5pc100_defconfig
> > @@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
> > # CONFIG_DEBUG_STACK_USAGE is not set
> > CONFIG_DEBUG_LL=y
> > # CONFIG_DEBUG_ICEDCC is not set
> > -CONFIG_DEBUG_S3C_PORT=y
> > CONFIG_DEBUG_S3C_UART=0
>
> no, there is no point removing redundant entries from any of the
> defconfig files -- those files will eventually be rebuilt
> automatically at some point.
>

Who will build defconfig for old architectures like h3600_defconfig and
others.

If we are removing unused CONFIG from Kconfig then there is no point of
leaving those entries in defconfigs after all git grep keep those
entries and lead to confusions sooner or later. Yeah, for this case
where we have only entry in defconfig you sounds good but let
maintainers will decide it :-)

Thanks,
--
JSR