2009-10-07 14:27:46

by Arnaldo Carvalho de Melo

Subject: [PATCH 1/1] perf tools: Install the docs by default

So that we get matching docs when installing a new version of the tools.

Cc: Frederic Weisbecker <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Jesse Brandeburg <[email protected]>
Suggested-by: Jesse Brandeburg <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 5a42996..e714bd1 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -895,6 +895,7 @@ ifneq (,$X)
$(foreach p,$(patsubst %$X,%,$(filter %$X,$(ALL_PROGRAMS) $(BUILT_INS) perf$X)), $(RM) '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/$p';)
endif
endif
+ $(MAKE) -C Documentation install

install-doc:
$(MAKE) -C Documentation install
--
1.6.2.5

2009-10-08 17:27:12

by Ingo Molnar

Subject: Re: [PATCH 1/1] perf tools: Install the docs by default

* Arnaldo Carvalho de Melo <[email protected]> wrote:

> So that we get matching docs when installing a new version of the tools.
>
> Cc: Frederic Weisbecker <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Mike Galbraith <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Jesse Brandeburg <[email protected]>
> Suggested-by: Jesse Brandeburg <[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
> ---
> tools/perf/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 5a42996..e714bd1 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -895,6 +895,7 @@ ifneq (,$X)
> $(foreach p,$(patsubst %$X,%,$(filter %$X,$(ALL_PROGRAMS) $(BUILT_INS) perf$X)), $(RM) '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/$p';)
> endif
> endif
> + $(MAKE) -C Documentation install
>
> install-doc:
> $(MAKE) -C Documentation install

hm, i didnt want to do that because many systems dont have asciidoc and
xmlto installed by default.

We can still do it, if you can auto-detect these two new tools and emit
a warning (and dont build+install) documentation if they are missing -
instead of failing the build.

Ingo