There is no platform dependence of SND_CS5535AUDIO before 2.6.31, Not
sure who have touched this part, but SND_CS5535AUDIO is at least
available on Loongson family machines, so, Remove the platform
dependence directly.
Reported-by: [email protected]
Signed-off-by: Wu Zhangjin <[email protected]>
---
sound/pci/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index fb5ee3c..75c602b 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -259,7 +259,6 @@ config SND_CS5530
config SND_CS5535AUDIO
tristate "CS5535/CS5536 Audio"
- depends on X86 && !X86_64
select SND_PCM
select SND_AC97_CODEC
help
--
1.6.2.1
On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> There is no platform dependence of SND_CS5535AUDIO before 2.6.31, Not
> sure who have touched this part, but SND_CS5535AUDIO is at least
> available on Loongson family machines, so, Remove the platform
> dependence directly.
>
> Reported-by: [email protected]
> Signed-off-by: Wu Zhangjin <[email protected]>
> ---
> sound/pci/Kconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> index fb5ee3c..75c602b 100644
> --- a/sound/pci/Kconfig
> +++ b/sound/pci/Kconfig
> @@ -259,7 +259,6 @@ config SND_CS5530
>
> config SND_CS5535AUDIO
> tristate "CS5535/CS5536 Audio"
> - depends on X86 && !X86_64
or use this?
depends on (X86 && !X86_64) || MIPS
Regards,
Wu Zhangjin
On Fri, 09 Oct 2009 11:51:27 +0800
Wu Zhangjin <[email protected]> wrote:
> On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > There is no platform dependence of SND_CS5535AUDIO before 2.6.31,
> > Not sure who have touched this part, but SND_CS5535AUDIO is at least
> > available on Loongson family machines, so, Remove the platform
> > dependence directly.
> >
> > Reported-by: [email protected]
> > Signed-off-by: Wu Zhangjin <[email protected]>
> > ---
> > sound/pci/Kconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > index fb5ee3c..75c602b 100644
> > --- a/sound/pci/Kconfig
> > +++ b/sound/pci/Kconfig
> > @@ -259,7 +259,6 @@ config SND_CS5530
> >
> > config SND_CS5535AUDIO
> > tristate "CS5535/CS5536 Audio"
> > - depends on X86 && !X86_64
>
> or use this?
>
> depends on (X86 && !X86_64) || MIPS
>
> Regards,
> Wu Zhangjin
>
I'd say just remove the arch dependency (and make sure it builds and
doesn't obviously explode w/ x86-64). There's no need for it, afaict.
It's been there since at least 2005 (git commit 230b5c1a).
Hello,
On Fri, 2009-10-09 at 00:53 -0400, Andres Salomon wrote:
> On Fri, 09 Oct 2009 11:51:27 +0800
> Wu Zhangjin <[email protected]> wrote:
>
> > On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > > There is no platform dependence of SND_CS5535AUDIO before 2.6.31,
> > > Not sure who have touched this part, but SND_CS5535AUDIO is at least
> > > available on Loongson family machines, so, Remove the platform
> > > dependence directly.
> > >
> > > Reported-by: [email protected]
> > > Signed-off-by: Wu Zhangjin <[email protected]>
> > > ---
> > > sound/pci/Kconfig | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > > index fb5ee3c..75c602b 100644
> > > --- a/sound/pci/Kconfig
> > > +++ b/sound/pci/Kconfig
> > > @@ -259,7 +259,6 @@ config SND_CS5530
> > >
> > > config SND_CS5535AUDIO
> > > tristate "CS5535/CS5536 Audio"
> > > - depends on X86 && !X86_64
> >
> > or use this?
> >
> > depends on (X86 && !X86_64) || MIPS
> >
> > Regards,
> > Wu Zhangjin
> >
>
>
> I'd say just remove the arch dependency (and make sure it builds and
> doesn't obviously explode w/ x86-64). There's no need for it, afaict.
> It's been there since at least 2005 (git commit 230b5c1a).
>
Just checked the SND_CS5536AUDIO(=y and =m) option with ARCH=x86_64, no
compiling warnings & errors, but I don't have such a chip in a x86-64
machine, so, did not test the kernel yet.
Regards,
Wu Zhangjin
On Sat, 10 Oct 2009 22:32:14 +0800
Wu Zhangjin <[email protected]> wrote:
> Hello,
>
> On Fri, 2009-10-09 at 00:53 -0400, Andres Salomon wrote:
> > On Fri, 09 Oct 2009 11:51:27 +0800
> > Wu Zhangjin <[email protected]> wrote:
> >
> > > On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > > > There is no platform dependence of SND_CS5535AUDIO before
> > > > 2.6.31, Not sure who have touched this part, but
> > > > SND_CS5535AUDIO is at least available on Loongson family
> > > > machines, so, Remove the platform dependence directly.
> > > >
> > > > Reported-by: [email protected]
> > > > Signed-off-by: Wu Zhangjin <[email protected]>
> > > > ---
> > > > sound/pci/Kconfig | 1 -
> > > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > > > index fb5ee3c..75c602b 100644
> > > > --- a/sound/pci/Kconfig
> > > > +++ b/sound/pci/Kconfig
> > > > @@ -259,7 +259,6 @@ config SND_CS5530
> > > >
> > > > config SND_CS5535AUDIO
> > > > tristate "CS5535/CS5536 Audio"
> > > > - depends on X86 && !X86_64
> > >
[...]
>
> Just checked the SND_CS5536AUDIO(=y and =m) option with ARCH=x86_64,
> no compiling warnings & errors, but I don't have such a chip in a
> x86-64 machine, so, did not test the kernel yet.
>
> Regards,
> Wu Zhangjin
>
Great, feel free to add
Acked-by: Andres Salomon <[email protected]>