2009-10-10 15:38:09

by Thomas Gleixner

[permalink] [raw]
Subject: [patch 13/28] s390: Remove BKL from prng

cycle_kernel_lock() was added during the big BKL pushdown. It should
ensure the serializiation against driver init code. In this case there
is nothing to serialize. Remove it.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
---
arch/s390/crypto/prng.c | 2 --
1 file changed, 2 deletions(-)

Index: linux-2.6-tip/arch/s390/crypto/prng.c
===================================================================
--- linux-2.6-tip.orig/arch/s390/crypto/prng.c
+++ linux-2.6-tip/arch/s390/crypto/prng.c
@@ -6,7 +6,6 @@
#include <linux/fs.h>
#include <linux/init.h>
#include <linux/kernel.h>
-#include <linux/smp_lock.h>
#include <linux/miscdevice.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
@@ -49,7 +48,6 @@ static unsigned char parm_block[32] = {

static int prng_open(struct inode *inode, struct file *file)
{
- cycle_kernel_lock();
return nonseekable_open(inode, file);
}



2009-10-13 10:38:04

by Jan Glauber

[permalink] [raw]
Subject: Re: [patch 13/28] s390: Remove BKL from prng

On Sat, 2009-10-10 at 15:36 +0000, Thomas Gleixner wrote:
> einfaches Textdokument attachment (s390-remove-bkl-from-prng.patch)
> cycle_kernel_lock() was added during the big BKL pushdown. It should
> ensure the serializiation against driver init code. In this case there
> is nothing to serialize. Remove it.

Looks good.
Acked-by: Jan Glauber <jang.linux.vnet.ibm.com>

-- Jan

> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Martin Schwidefsky <[email protected]>
> ---
> arch/s390/crypto/prng.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-2.6-tip/arch/s390/crypto/prng.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/s390/crypto/prng.c
> +++ linux-2.6-tip/arch/s390/crypto/prng.c
> @@ -6,7 +6,6 @@
> #include <linux/fs.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> -#include <linux/smp_lock.h>
> #include <linux/miscdevice.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> @@ -49,7 +48,6 @@ static unsigned char parm_block[32] = {
>
> static int prng_open(struct inode *inode, struct file *file)
> {
> - cycle_kernel_lock();
> return nonseekable_open(inode, file);
> }
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2009-10-14 15:46:32

by Thomas Gleixner

[permalink] [raw]
Subject: [tip:bkl/arch] s390: Remove BKL from prng

Commit-ID: ca1b82ba0888e742a7efdb89ed8e2aab453e091f
Gitweb: http://git.kernel.org/tip/ca1b82ba0888e742a7efdb89ed8e2aab453e091f
Author: Thomas Gleixner <[email protected]>
AuthorDate: Sat, 10 Oct 2009 10:21:03 +0200
Committer: Thomas Gleixner <[email protected]>
CommitDate: Wed, 14 Oct 2009 15:35:50 +0200

s390: Remove BKL from prng

cycle_kernel_lock() was added during the big BKL pushdown. It should
ensure the serializiation against driver init code. In this case there
is nothing to serialize. Remove it.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
LKML-Reference: <[email protected]>
Acked-by: Jan Glauber <[email protected]>

---
arch/s390/crypto/prng.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
index b49c00c..a320990 100644
--- a/arch/s390/crypto/prng.c
+++ b/arch/s390/crypto/prng.c
@@ -6,7 +6,6 @@
#include <linux/fs.h>
#include <linux/init.h>
#include <linux/kernel.h>
-#include <linux/smp_lock.h>
#include <linux/miscdevice.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
@@ -49,7 +48,6 @@ static unsigned char parm_block[32] = {

static int prng_open(struct inode *inode, struct file *file)
{
- cycle_kernel_lock();
return nonseekable_open(inode, file);
}