2009-10-19 14:46:22

by Mark Brown

Subject: [PATCH] mfd: Staticise __adp5520_ack_bits()

The function is not exported as the __ indicates. __

Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/adp5520.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index 401a9b6..b266447 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
return 0;
}

-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t bit_mask)
+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
+ uint8_t bit_mask)
{
struct adp5520_chip *chip = i2c_get_clientdata(client);
uint8_t reg_val;
--
1.6.5

2009-10-19 15:09:10

by Hennerich, Michael

Subject: RE: [PATCH] mfd: Staticise __adp5520_ack_bits()

>From: Mark Brown [mailto:[email protected]]
>The function is not exported as the __ indicates. __
>
>Signed-off-by: Mark Brown <[email protected]>


Acked-by: Michael Hennerich <[email protected]>


>---
> drivers/mfd/adp5520.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
>index 401a9b6..b266447 100644
>--- a/drivers/mfd/adp5520.c
>+++ b/drivers/mfd/adp5520.c
>@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
> return 0;
> }
>
>-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t
bit_mask)
>+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
>+ uint8_t bit_mask)
> {
> struct adp5520_chip *chip = i2c_get_clientdata(client);
> uint8_t reg_val;
>--
>1.6.5

-Michael

2009-10-19 22:24:39

by Samuel Ortiz

Subject: Re: [PATCH] mfd: Staticise __adp5520_ack_bits()

On Mon, Oct 19, 2009 at 04:09:07PM +0100, Hennerich, Michael wrote:
> >From: Mark Brown [mailto:[email protected]]
> >The function is not exported as the __ indicates. __
> >
> >Signed-off-by: Mark Brown <[email protected]>
>
>
> Acked-by: Michael Hennerich <[email protected]>
Thanks guys, applied to my for-next branch.

Cheers,
Samuel.

>
> >---
> > drivers/mfd/adp5520.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> >index 401a9b6..b266447 100644
> >--- a/drivers/mfd/adp5520.c
> >+++ b/drivers/mfd/adp5520.c
> >@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
> > return 0;
> > }
> >
> >-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t
> bit_mask)
> >+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
> >+ uint8_t bit_mask)
> > {
> > struct adp5520_chip *chip = i2c_get_clientdata(client);
> > uint8_t reg_val;
> >--
> >1.6.5
>
> -Michael

--
Intel Open Source Technology Centre
http://oss.intel.com/