Commit 3b073eda has removed pci_find_slot, so there's no point in
mentioning it in the config description as one of the deprecated APIs
there are enabled by PCI_LEGACY and still used by some drivers.
Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
---
drivers/pci/Kconfig | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index fdc864f..48a3ea7 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -27,10 +27,10 @@ config PCI_LEGACY
default y
help
Say Y here if you want to include support for the deprecated
- pci_find_slot() and pci_find_device() APIs. Most drivers have
- been converted over to using the proper hotplug APIs, so this
- option serves to include/exclude only a few drivers that are
- still using this API.
+ pci_find_device() API. Most drivers have been converted over
+ to using the proper hotplug APIs, so this option serves to
+ include/exclude only a few drivers that are still using this
+ API.
config PCI_DEBUG
bool "PCI Debugging"
--
1.6.3.3
On Fri, 30 Oct 2009, Thadeu Lima de Souza Cascardo wrote:
> Commit 3b073eda has removed pci_find_slot, so there's no point in
> mentioning it in the config description as one of the deprecated APIs
> there are enabled by PCI_LEGACY and still used by some drivers.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
> ---
> drivers/pci/Kconfig | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index fdc864f..48a3ea7 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -27,10 +27,10 @@ config PCI_LEGACY
> default y
> help
> Say Y here if you want to include support for the deprecated
> - pci_find_slot() and pci_find_device() APIs. Most drivers have
> - been converted over to using the proper hotplug APIs, so this
> - option serves to include/exclude only a few drivers that are
> - still using this API.
> + pci_find_device() API. Most drivers have been converted over
> + to using the proper hotplug APIs, so this option serves to
> + include/exclude only a few drivers that are still using this
> + API.
While you are at it, how about removing the references in
Documentation/PCI/pci.txt as well?
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
On Mon, Nov 02, 2009 at 04:49:01PM +0100, Jiri Kosina wrote:
> On Fri, 30 Oct 2009, Thadeu Lima de Souza Cascardo wrote:
>
> > Commit 3b073eda has removed pci_find_slot, so there's no point in
> > mentioning it in the config description as one of the deprecated APIs
> > there are enabled by PCI_LEGACY and still used by some drivers.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
> > ---
> > drivers/pci/Kconfig | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> > index fdc864f..48a3ea7 100644
> > --- a/drivers/pci/Kconfig
> > +++ b/drivers/pci/Kconfig
> > @@ -27,10 +27,10 @@ config PCI_LEGACY
> > default y
> > help
> > Say Y here if you want to include support for the deprecated
> > - pci_find_slot() and pci_find_device() APIs. Most drivers have
> > - been converted over to using the proper hotplug APIs, so this
> > - option serves to include/exclude only a few drivers that are
> > - still using this API.
> > + pci_find_device() API. Most drivers have been converted over
> > + to using the proper hotplug APIs, so this option serves to
> > + include/exclude only a few drivers that are still using this
> > + API.
>
> While you are at it, how about removing the references in
> Documentation/PCI/pci.txt as well?
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
I've hit them. But, on a first fast look, they seemed important
historically. I will take a closer look and point that if it's proper or
remove them entirely as you suggest.
Regards,
Cascardo.
* Thadeu Lima de Souza Cascardo <[email protected]>:
> On Mon, Nov 02, 2009 at 04:49:01PM +0100, Jiri Kosina wrote:
> > On Fri, 30 Oct 2009, Thadeu Lima de Souza Cascardo wrote:
> >
> > > Commit 3b073eda has removed pci_find_slot, so there's no point in
> > > mentioning it in the config description as one of the deprecated APIs
> > > there are enabled by PCI_LEGACY and still used by some drivers.
> >
> > While you are at it, how about removing the references in
> > Documentation/PCI/pci.txt as well?
>
> I've hit them. But, on a first fast look, they seemed important
> historically. I will take a closer look and point that if it's proper or
> remove them entirely as you suggest.
I think you can safely remove the references to the APIs that are
no longer in the kernel at all, such as pci_find_slot(), etc.
On the other hand, if an interface is still there but deprecated,
you can leave it in Documentation/PCI/pci.txt.
Thanks,
/ac
On Fri, 30 Oct 2009 17:46:48 -0200
Thadeu Lima de Souza Cascardo <[email protected]> wrote:
> Commit 3b073eda has removed pci_find_slot, so there's no point in
> mentioning it in the config description as one of the deprecated APIs
> there are enabled by PCI_LEGACY and still used by some drivers.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
> ---
Applied to linux-next. You can do the suggested pci.txt stuff in a
followup if you want.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center