2009-11-03 13:29:14

by Arnaldo Carvalho de Melo

Subject: [PATCH 1/1] perf probe: Annotate variable initialization

From: Arnaldo Carvalho de Melo <[email protected]>

cc1: warnings being treated as errors
builtin-probe.c: In function ‘parse_probe_event’:
builtin-probe.c:72: warning: ‘nc’ is used uninitialized in this function

Cc: Masami Hiramatsu <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-probe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index a99a366..8124523 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -69,7 +69,7 @@ static struct {
static void parse_probe_point(char *arg, struct probe_point *pp)
{
char *ptr, *tmp;
- char c, nc;
+ char c, nc = 0;
/*
* <Syntax>
* perf probe SRC:LN
--
1.5.5.1

2009-11-03 15:46:47

by Masami Hiramatsu

Subject: Re: [PATCH 1/1] perf probe: Annotate variable initialization

Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo<[email protected]>
>
> cc1: warnings being treated as errors
> builtin-probe.c: In function ‘parse_probe_event’:
> builtin-probe.c:72: warning: ‘nc’ is used uninitialized in this function
>
> Cc: Masami Hiramatsu<[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo<[email protected]>

Oops, thank you!

Acked-by: Masami Hiramatsu <[email protected]>

> ---
> tools/perf/builtin-probe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index a99a366..8124523 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -69,7 +69,7 @@ static struct {
> static void parse_probe_point(char *arg, struct probe_point *pp)
> {
> char *ptr, *tmp;
> - char c, nc;
> + char c, nc = 0;
> /*
> *<Syntax>
> * perf probe SRC:LN

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: [email protected]