2009-11-07 17:51:06

by Thiago Farina

Subject: [PATCH] leds: add exit function to cobalt-raq led.

Signed-off-by: Thiago Farina <[email protected]>
---
drivers/leds/leds-cobalt-raq.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/leds/leds-cobalt-raq.c b/drivers/leds/leds-cobalt-raq.c
index defc212..e43fcb2 100644
--- a/drivers/leds/leds-cobalt-raq.c
+++ b/drivers/leds/leds-cobalt-raq.c
@@ -135,4 +135,15 @@ static int __init cobalt_raq_led_init(void)
return platform_driver_register(&cobalt_raq_led_driver);
}

+static void __exit cobalt_raq_led_exit(void)
+{
+ platform_driver_unregister(&cobalt_raq_led_driver);
+}
+
module_init(cobalt_raq_led_init);
+module_exit(cobalt_raq_led_exit);
+
+MODULE_AUTHOR("Yoichi Yuasa <[email protected]>");
+MODULE_DESCRIPTION("LEDs driver for the Cobalt Raq series.");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:cobalt-raq-leds");
--
1.6.5.2.150.g1b52a

2009-11-07 23:44:16

by Ralf Baechle

Subject: Re: [PATCH] leds: add exit function to cobalt-raq led.

On Sat, Nov 07, 2009 at 12:50:35PM -0500, Thiago Farina wrote:

This driver has no exit function because it cannot be built as a module.
I've not reviewed the driver in detail but at the very least the
LEDS_COBALT_RAQ Kconfig statement for the driver would need to be changed
to tristate before this patch makes any sense.

Ralf

2009-11-07 23:55:59

by Thiago Farina

Subject: Re: [PATCH] leds: add exit function to cobalt-raq led.

On Sat, Nov 7, 2009 at 9:45 PM, Ralf Baechle <[email protected]> wrote:
> On Sat, Nov 07, 2009 at 12:50:35PM -0500, Thiago Farina wrote:
>
> This driver has no exit function because it cannot be built as a module.
> I've not reviewed the driver in detail but at the very least the
> LEDS_COBALT_RAQ Kconfig statement for the driver would need to be changed
> to tristate before this patch makes any sense.

According to this thread:
"Therefore, this driver is not tristate."
http://lkml.org/lkml/2007/9/13/377