2009-11-08 20:25:43

by Davidlohr Bueso

[permalink] [raw]
Subject: [PATCH 00/20] SCSI: No longer use Scsi_Cmd typedef

Plenty of older drivers are still using Scsi_Cmd. The following patches
remove its use and changes them for "struct scsi_cmnd". There is also no
need for the drivers/scsi/scsi_typedefs.h file anymore since this only
contains the typedef for Scsi_Cmd.

Thanks,
Davidlohr


drivers/scsi/NCR5380.c | 72 ++++++++++++++++---------------
drivers/scsi/NCR5380.h | 16 ++++----
drivers/scsi/NCR53c406a.c | 6 +-
drivers/scsi/aha152x.c | 68 +++++++++++++++---------------
drivers/scsi/aha1542.c | 30 +++++++-------
drivers/scsi/aha1542.h | 12 +++---
drivers/scsi/aha1740.c | 8 ++--
drivers/scsi/aha1740.h | 4 +-
drivers/scsi/atari_NCR5380.c | 94 +++++++++++++++++++++---------------------
drivers/scsi/atari_scsi.c | 12 +++---
drivers/scsi/atari_scsi.h | 2 +-
drivers/scsi/dtc.h | 6 +-
drivers/scsi/fd_mcs.c | 10 ++--
drivers/scsi/g_NCR5380.c | 10 ++--
drivers/scsi/g_NCR5380.h | 6 +-
drivers/scsi/gdth.c | 66 +++++++++++++++---------------
drivers/scsi/gdth.h | 10 ++--
drivers/scsi/gdth_proc.c | 2 +-
drivers/scsi/ibmmca.c | 28 ++++++------
drivers/scsi/in2000.c | 68 +++++++++++++++---------------
drivers/scsi/in2000.h | 14 +++---
drivers/scsi/megaraid.c | 28 ++++++------
drivers/scsi/megaraid.h | 18 ++++----
drivers/scsi/nsp32_debug.c | 2 +-
drivers/scsi/pas16.h | 6 +-
drivers/scsi/scsi.h | 3 -
drivers/scsi/sym53c416.c | 6 +-
drivers/scsi/sym53c416.h | 4 +-
drivers/scsi/wd7000.c | 2 +-
29 files changed, 306 insertions(+), 307 deletions(-)





2009-11-09 08:08:12

by Boaz Harrosh

[permalink] [raw]
Subject: Re: [PATCH 00/20] SCSI: No longer use Scsi_Cmd typedef

On 11/08/2009 10:16 PM, Davidlohr Bueso wrote:
> Plenty of older drivers are still using Scsi_Cmd. The following patches
> remove its use and changes them for "struct scsi_cmnd". There is also no
> need for the drivers/scsi/scsi_typedefs.h file anymore since this only
> contains the typedef for Scsi_Cmd.
>
> Thanks,
> Davidlohr
>
>
> drivers/scsi/NCR5380.c | 72 ++++++++++++++++---------------
> drivers/scsi/NCR5380.h | 16 ++++----
> drivers/scsi/NCR53c406a.c | 6 +-
> drivers/scsi/aha152x.c | 68 +++++++++++++++---------------
> drivers/scsi/aha1542.c | 30 +++++++-------
> drivers/scsi/aha1542.h | 12 +++---
> drivers/scsi/aha1740.c | 8 ++--
> drivers/scsi/aha1740.h | 4 +-
> drivers/scsi/atari_NCR5380.c | 94 +++++++++++++++++++++---------------------
> drivers/scsi/atari_scsi.c | 12 +++---
> drivers/scsi/atari_scsi.h | 2 +-
> drivers/scsi/dtc.h | 6 +-
> drivers/scsi/fd_mcs.c | 10 ++--
> drivers/scsi/g_NCR5380.c | 10 ++--
> drivers/scsi/g_NCR5380.h | 6 +-
> drivers/scsi/gdth.c | 66 +++++++++++++++---------------
> drivers/scsi/gdth.h | 10 ++--
> drivers/scsi/gdth_proc.c | 2 +-
> drivers/scsi/ibmmca.c | 28 ++++++------
> drivers/scsi/in2000.c | 68 +++++++++++++++---------------
> drivers/scsi/in2000.h | 14 +++---
> drivers/scsi/megaraid.c | 28 ++++++------
> drivers/scsi/megaraid.h | 18 ++++----
> drivers/scsi/nsp32_debug.c | 2 +-
> drivers/scsi/pas16.h | 6 +-
> drivers/scsi/scsi.h | 3 -
> drivers/scsi/sym53c416.c | 6 +-
> drivers/scsi/sym53c416.h | 4 +-
> drivers/scsi/wd7000.c | 2 +-
> 29 files changed, 306 insertions(+), 307 deletions(-)
>

Thanks for doing this. What a grate relief.

One thing that I'm missing is the actual patch to remove the
scsi_typedefs.h file. Is it still used?

Thanks
Boaz

2009-11-10 12:11:20

by Davidlohr Bueso

[permalink] [raw]
Subject: Re: [PATCH 00/20] SCSI: No longer use Scsi_Cmd typedef

On Mon, Nov 09, 2009 at 10:08:07AM +0200, Boaz Harrosh wrote:
> On 11/08/2009 10:16 PM, Davidlohr Bueso wrote:
> > Plenty of older drivers are still using Scsi_Cmd. The following patches
> > remove its use and changes them for "struct scsi_cmnd". There is also no
> > need for the drivers/scsi/scsi_typedefs.h file anymore since this only
> > contains the typedef for Scsi_Cmd.

>
> Thanks for doing this. What a grate relief.
>
> One thing that I'm missing is the actual patch to remove the
> scsi_typedefs.h file. Is it still used?

Oops, you're right, sending now.

Thanks,
Davidlohr

Signed-off-by: Davidlohr Bueso <[email protected]>

---
drivers/scsi/scsi_typedefs.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
delete mode 100644 drivers/scsi/scsi_typedefs.h

diff --git a/drivers/scsi/scsi_typedefs.h b/drivers/scsi/scsi_typedefs.h
deleted file mode 100644
index 2ed4c5c..0000000
--- a/drivers/scsi/scsi_typedefs.h
+++ /dev/null
@@ -1,2 +0,0 @@
-
-typedef struct scsi_cmnd Scsi_Cmnd;
--
1.6.3.3

2009-12-01 12:43:12

by Davidlohr Bueso

[permalink] [raw]
Subject: Re: [PATCH 00/20] SCSI: No longer use Scsi_Cmd typedef

> Thanks for doing this. What a grate relief.

Just following up on the status of the patch.

Thanks,
Davidlohr