2009-11-12 16:57:43

by Roel Kluin

Subject: [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal()

The returned error should stay negative

Signed-off-by: Roel Kluin <[email protected]>
---
fs/jffs2/readinode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index 1a80301..9c26738 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -1284,7 +1284,7 @@ static int jffs2_do_read_inode_internal(struct jffs2_sb_info *c,
f->target = NULL;
mutex_unlock(&f->sem);
jffs2_do_clear_inode(c, f);
- return -ret;
+ return ret;
}

f->target[je32_to_cpu(latest_node->csize)] = '\0';

2009-11-13 08:39:36

by Artem Bityutskiy

Subject: Re: [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal()

On Thu, 2009-11-12 at 18:09 +0100, Roel Kluin wrote:
> The returned error should stay negative
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> fs/jffs2/readinode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Taken to my l2-mtd-2.6 tree, thanks.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)