2009-11-14 08:31:37

by Stanislav O. Bezzubtsev

Subject: [PATCH] forcedeth: mac address fix

Use the existing random_ether_addr() to generate random MAC
instead of doing it by-hand.

Signed-off-by: Stanislav O. Bezzubtsev <[email protected]>
---
drivers/net/forcedeth.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index e1da466..3116601 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -5821,10 +5821,7 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
dev->dev_addr);
dev_printk(KERN_ERR, &pci_dev->dev,
"Please complain to your hardware vendor. Switching to a random MAC.\n");
- dev->dev_addr[0] = 0x00;
- dev->dev_addr[1] = 0x00;
- dev->dev_addr[2] = 0x6c;
- get_random_bytes(&dev->dev_addr[3], 3);
+ random_ether_addr(dev->dev_addr);
}

dprintk(KERN_DEBUG "%s: MAC Address %pM\n",
--
1.6.5

2009-11-16 05:16:58

by David Miller

Subject: Re: [PATCH] forcedeth: mac address fix

From: "Stanislav O\. Bezzubtsev" <[email protected]>
Date: Sat, 14 Nov 2009 11:31:25 +0300

> Use the existing random_ether_addr() to generate random MAC
> instead of doing it by-hand.
>
> Signed-off-by: Stanislav O. Bezzubtsev <[email protected]>

Applied, thank you.