2009-11-09 11:07:18

by Soeren Sonnenburg

[permalink] [raw]
Subject: [PATCH] mouse button 1 emulation for mac_hid

(this is a resent with all the people included in the CC that git
blame'd they are the authors).

Dear all,

I am not sure what the future of mac_hid is (the source says will be
removed, but since 9 years). In case it stays in kernel the attached
patch adds support for mouse button 1 emulation. If this driver stays in
the kernel I would also suggest to rename it - it is not mac specific (I
am using this on a netbook).

Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
where click and hold + moving the mouse does not work (yet?).

I am using this for over a week now with about that uptime - so it
should be safe.

Soeren
--
For the one fact about the future of which we can be certain is that it
will be utterly fantastic. -- Arthur C. Clarke, 1962


Attachments:
mac_hid_lmb.diff (3.22 kB)
signature.asc (836.00 B)
This is a digitally signed message part
Download all attachments

2009-11-14 05:42:48

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] mouse button 1 emulation for mac_hid

Hi Soeren,

On Mon, Nov 09, 2009 at 11:28:51AM +0100, Soeren Sonnenburg wrote:
> (this is a resent with all the people included in the CC that git
> blame'd they are the authors).
>
> Dear all,
>
> I am not sure what the future of mac_hid is (the source says will be
> removed, but since 9 years). In case it stays in kernel the attached
> patch adds support for mouse button 1 emulation. If this driver stays in
> the kernel I would also suggest to rename it - it is not mac specific (I
> am using this on a netbook).
>
> Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
> where click and hold + moving the mouse does not work (yet?).
>

I would rather fix the touchpads so they work properly than pile more
quirks in kernel.

Thanks.

--
Dmitry

2009-11-14 10:31:42

by Soeren Sonnenburg

[permalink] [raw]
Subject: Re: [PATCH] mouse button 1 emulation for mac_hid

On Fri, 2009-11-13 at 21:42 -0800, Dmitry Torokhov wrote:
> Hi Soeren,

Hi Dmitry,

> On Mon, Nov 09, 2009 at 11:28:51AM +0100, Soeren Sonnenburg wrote:
> > (this is a resent with all the people included in the CC that git
> > blame'd they are the authors).
> >
> > Dear all,
> >
> > I am not sure what the future of mac_hid is (the source says will be
> > removed, but since 9 years). In case it stays in kernel the attached
> > patch adds support for mouse button 1 emulation. If this driver stays in
> > the kernel I would also suggest to rename it - it is not mac specific (I
> > am using this on a netbook).
> >
> > Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
> > where click and hold + moving the mouse does not work (yet?).
> >
>
> I would rather fix the touchpads so they work properly than pile more
> quirks in kernel.

Well I guess this whole mouse button emulation should not exist (not
only not in the kernel). But given that it is hard to fix a touchpad
that has no or only one mouse button ... I don't know.

Anyway, the patch is really small/non-intrusive but if it is not
appropriate I can - thanks to git - easily have it in some local
branch :)

Soeren
--
For the one fact about the future of which we can be certain is that it
will be utterly fantastic. -- Arthur C. Clarke, 1962


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part

2009-11-16 12:59:35

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH] mouse button 1 emulation for mac_hid

On Fri, 13 Nov 2009, Dmitry Torokhov wrote:

> > I am not sure what the future of mac_hid is (the source says will be
> > removed, but since 9 years). In case it stays in kernel the attached
> > patch adds support for mouse button 1 emulation. If this driver stays in
> > the kernel I would also suggest to rename it - it is not mac specific (I
> > am using this on a netbook).
> >
> > Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
> > where click and hold + moving the mouse does not work (yet?).
>
> I would rather fix the touchpads so they work properly than pile more
> quirks in kernel.

Hi Dmitry,

in exactly what way are you planning to "fix the touchpads"?

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-11-16 17:05:47

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] mouse button 1 emulation for mac_hid

On Mon, Nov 16, 2009 at 01:59:37PM +0100, Jiri Kosina wrote:
> On Fri, 13 Nov 2009, Dmitry Torokhov wrote:
>
> > > I am not sure what the future of mac_hid is (the source says will be
> > > removed, but since 9 years). In case it stays in kernel the attached
> > > patch adds support for mouse button 1 emulation. If this driver stays in
> > > the kernel I would also suggest to rename it - it is not mac specific (I
> > > am using this on a netbook).
> > >
> > > Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
> > > where click and hold + moving the mouse does not work (yet?).
> >
> > I would rather fix the touchpads so they work properly than pile more
> > quirks in kernel.
>
> Hi Dmitry,
>
> in exactly what way are you planning to "fix the touchpads"?
>

Hi Jiri,

It would be helpful to know which ones are currently. Obviously we can't
help with physically broken ones but I don't believe it is kernel's task
to deal with physically broken hardware. The ones that are not
physically broken - PS/2 should have fairly decent hardware emulation
mode (at least all I tried supported tap and trag while working as
regular PS/2 mouse) - so that can be used while we figuring out native
protocol. USB - appletouch, bcm - are there any issues at the moment?

--
Dmitry

2009-11-16 17:11:48

by Soeren Sonnenburg

[permalink] [raw]
Subject: Re: [PATCH] mouse button 1 emulation for mac_hid

On Mon, 2009-11-16 at 09:05 -0800, Dmitry Torokhov wrote:
> On Mon, Nov 16, 2009 at 01:59:37PM +0100, Jiri Kosina wrote:
> > On Fri, 13 Nov 2009, Dmitry Torokhov wrote:
> >
> > > > I am not sure what the future of mac_hid is (the source says will be
> > > > removed, but since 9 years). In case it stays in kernel the attached
> > > > patch adds support for mouse button 1 emulation. If this driver stays in
> > > > the kernel I would also suggest to rename it - it is not mac specific (I
> > > > am using this on a netbook).
> > > >
> > > > Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
> > > > where click and hold + moving the mouse does not work (yet?).
> > >
> > > I would rather fix the touchpads so they work properly than pile more
> > > quirks in kernel.
> >
> > Hi Dmitry,
> >
> > in exactly what way are you planning to "fix the touchpads"?
> >
>
> Hi Jiri,
>
> It would be helpful to know which ones are currently. Obviously we can't
> help with physically broken ones but I don't believe it is kernel's task
> to deal with physically broken hardware. The ones that are not
> physically broken - PS/2 should have fairly decent hardware emulation
> mode (at least all I tried supported tap and trag while working as
> regular PS/2 mouse) - so that can be used while we figuring out native
> protocol. USB - appletouch, bcm - are there any issues at the moment?

Ignoring broken hardware, there is the problem or feature that some
touchpads have the mouse *under the touchpad*. So when you click there
and want to move the mouse - well good luck. Of course this is something
that needs to be ultimately fixed in the synaptics xorg driver.

Soeren
--
For the one fact about the future of which we can be certain is that it
will be utterly fantastic. -- Arthur C. Clarke, 1962


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part