2009-11-22 08:18:09

by Jaswinder Singh Rajput

Subject: [PATCH] writeback: Fix missing kernel-doc notation

Fix the following htmldocs warning:

Warning(fs/fs-writeback.c:255): No description found for parameter 'sb'

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Wu Fengguang <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Randy Dunlap <[email protected]>
---
fs/fs-writeback.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 9d5360c..b15c97f 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -242,6 +242,7 @@ static void bdi_sync_writeback(struct backing_dev_info *bdi,
/**
* bdi_start_writeback - start writeback
* @bdi: the backing device to write from
+ * @sb: write inodes from this super_block
* @nr_pages: the number of pages to write
*
* Description:
--
1.6.5.3

2009-11-22 12:34:48

by Fengguang Wu

Subject: Re: [PATCH] writeback: Fix missing kernel-doc notation

Acked-by: Wu Fengguang <[email protected]>

Thanks!

On Sun, Nov 22, 2009 at 04:16:09PM +0800, Jaswinder Singh Rajput wrote:
>
> Fix the following htmldocs warning:
>
> Warning(fs/fs-writeback.c:255): No description found for parameter 'sb'
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> Cc: Wu Fengguang <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Jan Kara <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> ---
> fs/fs-writeback.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 9d5360c..b15c97f 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -242,6 +242,7 @@ static void bdi_sync_writeback(struct backing_dev_info *bdi,
> /**
> * bdi_start_writeback - start writeback
> * @bdi: the backing device to write from
> + * @sb: write inodes from this super_block
> * @nr_pages: the number of pages to write
> *
> * Description:
> --
> 1.6.5.3
>

2009-12-11 20:31:42

by Randy Dunlap

Subject: Re: [PATCH] writeback: Fix missing kernel-doc notation

On Sun, 22 Nov 2009 20:33:47 +0800 Wu Fengguang wrote:

>
> Acked-by: Wu Fengguang <[email protected]>
>
> Thanks!

applied, thanks.


> On Sun, Nov 22, 2009 at 04:16:09PM +0800, Jaswinder Singh Rajput wrote:
> >
> > Fix the following htmldocs warning:
> >
> > Warning(fs/fs-writeback.c:255): No description found for parameter 'sb'
> >
> > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> > Cc: Wu Fengguang <[email protected]>
> > Cc: Peter Zijlstra <[email protected]>
> > Cc: Jan Kara <[email protected]>
> > Cc: Jens Axboe <[email protected]>
> > Cc: Randy Dunlap <[email protected]>
> > ---
> > fs/fs-writeback.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> > index 9d5360c..b15c97f 100644
> > --- a/fs/fs-writeback.c
> > +++ b/fs/fs-writeback.c
> > @@ -242,6 +242,7 @@ static void bdi_sync_writeback(struct backing_dev_info *bdi,
> > /**
> > * bdi_start_writeback - start writeback
> > * @bdi: the backing device to write from
> > + * @sb: write inodes from this super_block
> > * @nr_pages: the number of pages to write
> > *
> > * Description:
> > --


---
~Randy