2009-12-03 16:38:45

by Michal Marek

Subject: [PATCH] m32r: really fix arch/m32r/boot/compressed/Makefile

Commit a556bec changed the variable from suffix_y to suffix-y only in
one place, change the rest to make it work again.

Signed-off-by: Michal Marek <[email protected]>
---
arch/m32r/boot/compressed/Makefile | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/m32r/boot/compressed/Makefile b/arch/m32r/boot/compressed/Makefile
index 177716b..01729c2 100644
--- a/arch/m32r/boot/compressed/Makefile
+++ b/arch/m32r/boot/compressed/Makefile
@@ -43,9 +43,9 @@ endif

OBJCOPYFLAGS += -R .empty_zero_page

-suffix_$(CONFIG_KERNEL_GZIP) = gz
-suffix_$(CONFIG_KERNEL_BZIP2) = bz2
-suffix_$(CONFIG_KERNEL_LZMA) = lzma
+suffix-$(CONFIG_KERNEL_GZIP) = gz
+suffix-$(CONFIG_KERNEL_BZIP2) = bz2
+suffix-$(CONFIG_KERNEL_LZMA) = lzma

$(obj)/piggy.o: $(obj)/vmlinux.scr $(obj)/vmlinux.bin.$(suffix-y) FORCE
$(call if_changed,ld)
--
1.6.5.3

2009-12-04 01:33:53

by Hirokazu Takata

Subject: Re: [PATCH] m32r: really fix arch/m32r/boot/compressed/Makefile

From: Michal Marek <[email protected]>
Subject: [PATCH] m32r: really fix arch/m32r/boot/compressed/Makefile
Date: Thu, 03 Dec 2009 16:38:17 +0000
> Commit a556bec changed the variable from suffix_y to suffix-y only in
> one place, change the rest to make it work again.
>
> Signed-off-by: Michal Marek <[email protected]>
> ---
> arch/m32r/boot/compressed/Makefile | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/m32r/boot/compressed/Makefile b/arch/m32r/boot/compressed/Makefile
> index 177716b..01729c2 100644
> --- a/arch/m32r/boot/compressed/Makefile
> +++ b/arch/m32r/boot/compressed/Makefile
> @@ -43,9 +43,9 @@ endif
>
> OBJCOPYFLAGS += -R .empty_zero_page
>
> -suffix_$(CONFIG_KERNEL_GZIP) = gz
> -suffix_$(CONFIG_KERNEL_BZIP2) = bz2
> -suffix_$(CONFIG_KERNEL_LZMA) = lzma
> +suffix-$(CONFIG_KERNEL_GZIP) = gz
> +suffix-$(CONFIG_KERNEL_BZIP2) = bz2
> +suffix-$(CONFIG_KERNEL_LZMA) = lzma
>
> $(obj)/piggy.o: $(obj)/vmlinux.scr $(obj)/vmlinux.bin.$(suffix-y) FORCE
> $(call if_changed,ld)
> --
> 1.6.5.3
>

Acked-by: Hirokazu Takata <[email protected]>

Thanks for letting me know.

Indeed, the Commit a556bec was not sufficient.

I've personally fixed this problem but not sent a pull request
to merge it yet.

-- Takata