2009-12-07 13:20:34

by Roel Kluin

Subject: [PATCH] UBIFS: PTR_ERR return of wrong pointer in check_leaf()

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <[email protected]>
---
fs/ubifs/debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index dbc093a..8a771c5 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2014,7 +2014,7 @@ static int check_leaf(struct ubifs_info *c, struct ubifs_zbranch *zbr,
inum = key_inum_flash(c, &dent->key);
fscki1 = read_add_inode(c, priv, inum);
if (IS_ERR(fscki1)) {
- err = PTR_ERR(fscki);
+ err = PTR_ERR(fscki1);
ubifs_err("error %d while processing entry node and "
"trying to find parent inode node %lu",
err, (unsigned long)inum);

2009-12-08 12:25:31

by Artem Bityutskiy

Subject: Re: [PATCH] UBIFS: PTR_ERR return of wrong pointer in check_leaf()

On Mon, 2009-12-07 at 14:21 +0100, Roel Kluin wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> fs/ubifs/debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Pushed to ubifs-2.6.git tree, thanks!

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)