2009-12-09 11:55:16

by Mike Frysinger

Subject: [PATCH] gen_init_cpio: fixed fwrite warning

On compilers with security warnings enabled by default, we get:

usr/gen_init_cpio.c: In function ‘cpio_mkfile’:
usr/gen_init_cpio.c:357: warning: ignoring return value of ‘fwrite’,
declared with attribute warn_unused_result

So check the return value and handle errors accordingly.

Signed-off-by: Mike Frysinger <[email protected]>
---
usr/gen_init_cpio.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
index 83b3dde..b2b3c2d 100644
--- a/usr/gen_init_cpio.c
+++ b/usr/gen_init_cpio.c
@@ -354,7 +354,10 @@ static int cpio_mkfile(const char *name, const char *location,
push_pad();

if (size) {
- fwrite(filebuf, size, 1, stdout);
+ if (fwrite(filebuf, size, 1, stdout) != 1) {
+ fprintf(stderr, "writing filebuf failed\n");
+ goto error;
+ }
offset += size;
push_pad();
}
--
1.6.5.5

2009-12-09 12:48:20

by Michal Marek

Subject: Re: [PATCH] gen_init_cpio: fixed fwrite warning

On 9.12.2009 12:55, Mike Frysinger wrote:
> On compilers with security warnings enabled by default, we get:
>
> usr/gen_init_cpio.c: In function ‘cpio_mkfile’:
> usr/gen_init_cpio.c:357: warning: ignoring return value of ‘fwrite’,
> declared with attribute warn_unused_result
>
> So check the return value and handle errors accordingly.
>
> Signed-off-by: Mike Frysinger <[email protected]>

Applied, thanks.

Michal