2009-12-11 15:29:49

by Herbert Xu

Subject: hwrng: pasemi - Use __devexit_p

Found this while trying to track down section mismatches in hwrng.

commit af304da7bbc35a72828cd8c5ef3c4e62ddaf0518
Author: Herbert Xu <[email protected]>
Date: Fri Dec 11 23:13:33 2009 +0800

hwrng: pasemi - Use __devexit_p

We must wrap __devexit functions with __devexit_p.

Signed-off-by: Herbert Xu <[email protected]>

diff --git a/drivers/char/hw_random/pasemi-rng.c b/drivers/char/hw_random/pasemi-rng.c
index 7fa61dd..5ec40af 100644
--- a/drivers/char/hw_random/pasemi-rng.c
+++ b/drivers/char/hw_random/pasemi-rng.c
@@ -143,7 +143,7 @@ static struct of_platform_driver rng_driver = {
.name = "pasemi-rng",
.match_table = rng_match,
.probe = rng_probe,
- .remove = rng_remove,
+ .remove = __devexit_p(rng_remove),
};

static int __init rng_init(void)
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2009-12-11 18:35:29

by Matt Mackall

Subject: Re: hwrng: pasemi - Use __devexit_p

On Fri, 2009-12-11 at 23:29 +0800, Herbert Xu wrote:
> Found this while trying to track down section mismatches in hwrng.

Gotta love those.

Acked-by: Matt Mackall <[email protected]>

--
http://selenic.com : development and support for Mercurial and Linux