2009-12-18 16:01:58

by Jani Nikula

[permalink] [raw]
Subject: [PATCH] gpiolib: fix poll(2) support reconfigure on sysfs polarity change

From: Jani Nikula <[email protected]>

Previously enabled poll(2) support on one edge was never reconfigured
when sysfs polarity change was triggered from kernel, because 'struct
device *dev' shadowed an earlier definition.

Found by sparse, which I should've run much earlier.

Signed-off-by: Jani Nikula <[email protected]>
---
drivers/gpio/gpiolib.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index a25ad28..350842a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -858,8 +858,6 @@ int gpio_sysfs_set_active_low(unsigned gpio, int value)
desc = &gpio_desc[gpio];

if (test_bit(FLAG_EXPORT, &desc->flags)) {
- struct device *dev;
-
dev = class_find_device(&gpio_class, NULL, desc, match_export);
if (dev == NULL) {
status = -ENODEV;
--
1.6.5.2