2009-12-29 23:49:42

by René Bolldorf

Subject: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'

The variable 'value' is unused in 'set_reset_quirk()'.

Greetings Ren? Bolldorf

--- ./drivers/usb/core/sysfs.c 2009-12-29 23:57:30.579982912 +0100
+++ ./drivers/usb/core/sysfs.c 2009-12-29 23:58:19.114982484 +0100
@@ -198,7 +198,7 @@ set_reset_quirk(struct device *dev, stru
const char *buf, size_t count)
{
struct usb_device *udev = to_usb_device(dev);
- int config, value;
+ int config;

if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1)
return -EINVAL;

2009-12-30 00:02:00

by Felipe Balbi

Subject: Re: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'

On Wed, 2009-12-30 at 00:49 +0100, René Bolldorf wrote:
> The variable 'value' is unused in 'set_reset_quirk()'.
>
> Greetings René Bolldorf

I already sent a patch for that [1]

[1] http://marc.info/?l=linux-usb&m=126203765207545&w=2

--
balbi

2009-12-30 11:27:24

by Sergei Shtylyov

Subject: Re: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'

Hello.

Felipe Balbi wrote:

>> The variable 'value' is unused in 'set_reset_quirk()'.
>>
>> Greetings René Bolldorf
>>
>
> I already sent a patch for that [1]
>
> [1] http://marc.info/?l=linux-usb&m=126203765207545&w=2
>

And you weren't the first one:

http://marc.info/?l=linux-usb&m=126165643307894


WBR, Sergei

2009-12-30 12:17:09

by Felipe Balbi

Subject: Re: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'

On Wed, 2009-12-30 at 14:27 +0300, Sergei Shtylyov wrote:
> Hello.
>
> Felipe Balbi wrote:
>
> >> The variable 'value' is unused in 'set_reset_quirk()'.
> >>
> >> Greetings René Bolldorf
> >>
> >
> > I already sent a patch for that [1]
> >
> > [1] http://marc.info/?l=linux-usb&m=126203765207545&w=2
> >
>
> And you weren't the first one:
>
> http://marc.info/?l=linux-usb&m=126165643307894

hah, beat me by a few days :-p


--
balbi