2010-01-10 14:29:24

by Atsushi Nemoto

Subject: [PATCH] compat_ioctl: Supress "unknown cmd" message on serial /dev/console

After the commit fb07a5f8 ("compat_ioctl: remove all VT ioctl
handling"), I got this error message on 64-bit mips kernel with 32-bit
busybox userland:

ioctl32(init:1): Unknown cmd fd(0) cmd(00005600){t:'V';sz:0} arg(7fd76480) on /dev/console

The cmd 5600 is VT_OPENQRY. The busybox's init issues this ioctl to
know vt-console or serial-console. If the console was serial console,
VT ioctls are not handled by the serial driver.

And by quick search, I found some programs using VT_GETMODE to check
vt-console is available or not.

Signed-off-by: Atsushi Nemoto <[email protected]>
---
fs/compat_ioctl.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 332dd00..c5c45de 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1005,6 +1005,9 @@ COMPATIBLE_IOCTL(SCSI_IOCTL_SEND_COMMAND)
COMPATIBLE_IOCTL(SCSI_IOCTL_PROBE_HOST)
COMPATIBLE_IOCTL(SCSI_IOCTL_GET_PCI)
#endif
+/* Big V (don't complain on serial console) */
+IGNORE_IOCTL(VT_OPENQRY)
+IGNORE_IOCTL(VT_GETMODE)
/* Little p (/dev/rtc, /dev/envctrl, etc.) */
COMPATIBLE_IOCTL(RTC_AIE_ON)
COMPATIBLE_IOCTL(RTC_AIE_OFF)
--
1.5.6.5

2010-01-16 08:03:16

by Arnd Bergmann

Subject: Re: [PATCH] compat_ioctl: Supress "unknown cmd" message on serial /dev/console

On Sunday 10 January 2010, Atsushi Nemoto wrote:
> After the commit fb07a5f8 ("compat_ioctl: remove all VT ioctl
> handling"), I got this error message on 64-bit mips kernel with 32-bit
> busybox userland:
>
> ioctl32(init:1): Unknown cmd fd(0) cmd(00005600){t:'V';sz:0} arg(7fd76480) on /dev/console
>
> The cmd 5600 is VT_OPENQRY. The busybox's init issues this ioctl to
> know vt-console or serial-console. If the console was serial console,
> VT ioctls are not handled by the serial driver.
>
> And by quick search, I found some programs using VT_GETMODE to check
> vt-console is available or not.
>
> Signed-off-by: Atsushi Nemoto <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>

Thanks for adding it to your tree, Greg. I'm a bit slow on
email currently, as I'm travelling.

Arnd