2010-01-22 18:18:24

by Himanshu Chauhan

Subject: [PATCH] USB-IP: Small clean up based on previous comments.

Hi,

I am trying to take a look at usb-ip to get it into mainline.
This is a small patch (my first patch ever) in this regard.

Please let me know the comments.

Thanks

Regards
Himanshu

Signed-off-by: Himanshu Chauhan <[email protected]>
---
drivers/staging/usbip/usbip_common.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
index ddb6f5f..57c0ff5 100644
--- a/drivers/staging/usbip/usbip_common.c
+++ b/drivers/staging/usbip/usbip_common.c
@@ -55,10 +55,7 @@ static ssize_t show_flag(struct device *dev, struct device_attribute *attr,
static ssize_t store_flag(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
- unsigned long flag;
-
- sscanf(buf, "%lx", &flag);
- usbip_debug_flag = flag;
+ sscanf(buf, "%lx", &usbip_debug_flag);

return count;
}
--
1.6.3.3

2010-01-22 18:18:27

by Himanshu Chauhan

Subject: [PATCH] USB-IP: Small clean up based on previous comments.

Hi,

I am trying to take a look at usb-ip to get it into mainline.
This is a small patch (my first patch ever) in this regard.

Please let me know the comments.

Thanks

Regards
Himanshu

---
drivers/staging/usbip/usbip_common.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
index ddb6f5f..57c0ff5 100644
--- a/drivers/staging/usbip/usbip_common.c
+++ b/drivers/staging/usbip/usbip_common.c
@@ -55,10 +55,7 @@ static ssize_t show_flag(struct device *dev, struct device_attribute *attr,
static ssize_t store_flag(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
- unsigned long flag;
-
- sscanf(buf, "%lx", &flag);
- usbip_debug_flag = flag;
+ sscanf(buf, "%lx", &usbip_debug_flag);

return count;
}
--
1.6.3.3