2010-01-19 04:08:44

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: backlight tree build warning

Hi Richard,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/video/backlight/l4f00242t03.o

Introduced by commit 1bb615b563230e690b332dae4fda0067c2f88bbc
("backlight: Add Epson L4F00242T03 LCD driver").

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

Attachments:
(No filename) (384.00 B)
 (No filename) (198.00 B)
 Download all attachments

2010-01-19 08:29:24

by Alberto Panizzo

[permalink] [raw]
Subject: Re: linux-next: backlight tree build warning

On mar, 2010-01-19 at 15:08 +1100, Stephen Rothwell wrote:
> Hi Richard,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/video/backlight/l4f00242t03.o
>
> Introduced by commit 1bb615b563230e690b332dae4fda0067c2f88bbc
> ("backlight: Add Epson L4F00242T03 LCD driver").
>

Mm I don't know what it goes wrong but metadata of that patch indicate
to create the file l4f00242t03.c with one line less (the module licence).
Sorry me, surely is my fault.

Fixing patch in response..

Alberto!

2010-01-19 08:30:55

by Alberto Panizzo

[permalink] [raw]
Subject: [PATCH] backlight: l4f00242t03: Fix module licence absence.



Signed-off-by: Alberto Panizzo <[email protected]>
---
drivers/video/backlight/l4f00242t03.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index 42d061e..74abd69 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -254,3 +254,4 @@ module_exit(l4f00242t03_exit);

MODULE_AUTHOR("Alberto Panizzo <[email protected]>");
MODULE_DESCRIPTION("EPSON L4F00242T03 LCD");
+MODULE_LICENSE("GPL v2");
--
1.6.3.3


2010-01-27 11:10:13

by Alberto Panizzo

[permalink] [raw]
Subject: Re: [PATCH] backlight: l4f00242t03: Fix module licence absence.


Signed-off-by: Alberto Panizzo <[email protected]>
---

Richard, can you pick this for "for-mm" branch of backlight tree?
in previous mail I explain my mistake..
Thanks.


drivers/video/backlight/l4f00242t03.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index 42d061e..74abd69 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -254,3 +254,4 @@ module_exit(l4f00242t03_exit);

MODULE_AUTHOR("Alberto Panizzo <[email protected]>");
MODULE_DESCRIPTION("EPSON L4F00242T03 LCD");
+MODULE_LICENSE("GPL v2");
--
1.6.3.3

2010-02-11 16:07:30

by Alberto Panizzo

[permalink] [raw]
Subject: Re: [PATCH] backlight: l4f00242t03: Fix module licence absence.

Signed-off-by: Alberto Panizzo <[email protected]>
---

Richard, can you pick this for "for-mm" branch of backlight tree?
in previous mail I explain my mistake..
Thanks.


drivers/video/backlight/l4f00242t03.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index 42d061e..74abd69 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -254,3 +254,4 @@ module_exit(l4f00242t03_exit);

MODULE_AUTHOR("Alberto Panizzo <[email protected]>");
MODULE_DESCRIPTION("EPSON L4F00242T03 LCD");
+MODULE_LICENSE("GPL v2");
--
1.6.3.3

2010-02-11 16:36:28

by Richard Purdie

[permalink] [raw]
Subject: Re: [PATCH] backlight: l4f00242t03: Fix module licence absence.

On Thu, 2010-02-11 at 17:07 +0100, Alberto Panizzo wrote:
> Signed-off-by: Alberto Panizzo <[email protected]>
> ---
>
> Richard, can you pick this for "for-mm" branch of backlight tree?
> in previous mail I explain my mistake..
> Thanks.

Applied, sorry about the delay.

Richard

--
Richard Purdie
Intel Open Source Technology Centre

2010-02-11 17:25:41

by Alberto Panizzo

[permalink] [raw]
Subject: Re: [PATCH] backlight: l4f00242t03: Fix module licence absence.

On gio, 2010-02-11 at 16:36 +0000, Richard Purdie wrote:
> On Thu, 2010-02-11 at 17:07 +0100, Alberto Panizzo wrote:
> > Signed-off-by: Alberto Panizzo <[email protected]>
> > ---
> >
> > Richard, can you pick this for "for-mm" branch of backlight tree?
> > in previous mail I explain my mistake..
> > Thanks.
>
> Applied, sorry about the delay.
>
> Richard
>
Thank you. Greg Kroah-Hartman at the FOSDEM says:
"Be Persistent!"

Best regards!

--
Alberto!