2010-02-11 17:22:54

by Mark Brown

Subject: [PATCH] regulator: Assume regulators are enabled if they don't report anything

If a regulator driver does not provide a way to query if the driver is
enabled then assume that it is enabled. This is very likely to reflect
the actual state is more useful for callers than reporting an error.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 5a3509b..7f9177f 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1466,9 +1466,9 @@ EXPORT_SYMBOL_GPL(regulator_force_disable);

static int _regulator_is_enabled(struct regulator_dev *rdev)
{
- /* sanity check */
+ /* If we don't know then assume that the regulator is always on */
if (!rdev->desc->ops->is_enabled)
- return -EINVAL;
+ return 1;

return rdev->desc->ops->is_enabled(rdev);
}
--
1.6.6.1

2010-02-12 11:20:54

by Liam Girdwood

Subject: Re: [PATCH] regulator: Assume regulators are enabled if they don't report anything

On Thu, 2010-02-11 at 17:22 +0000, Mark Brown wrote:
> If a regulator driver does not provide a way to query if the driver is
> enabled then assume that it is enabled. This is very likely to reflect
> the actual state is more useful for callers than reporting an error.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---

Applied.

Thanks

Liam

--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk